[GRASS-QA] GRASS QA: hamish |points.c draw.c grid.c main.c ...| no
clones | 4 monsters |6 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Mar 23 17:52:52 EDT 2011
Hello hamish,
here's a report on your recent grass-SVN change for the revision : 45729
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/display/d.barb/points.c
*****************************************************************
Function
count_pts_in_region(Begins at: 109, Ends at:150)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 42 | | OK | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
do_barb_points(Begins at: 10, Ends at:106)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 25 | * | WARNING | 25 |
LOC: | 97 | * | WARNING | 97 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
fill_arrays(Begins at: 155, Ends at:269)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | * | WARNING | 19 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 35 | * | WARNING | 35 |
LOC: | 115 | * | WARNING | 115 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
max_magnitude(Begins at: 273, Ends at:282)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/draw.c
*****************************************************************
Function
arrow_360(Begins at: 50, Ends at:55)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
arrow_mag(Begins at: 60, Ends at:102)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
draw_barb(Begins at: 15, Ends at:47)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 10 | | OK | 10 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
draw_circle(Begins at: 166, Ends at:208)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
draw_feather(Begins at: 214, Ends at:361)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 163 | *** | MONSTER | 163 |
LOC: | 148 | ** | BABY-MONSTER | 148 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
mark_the_spot(Begins at: 124, Ends at:160)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | | OK | 10 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
unknown_(Begins at: 107, Ends at:121)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/grid.c
*****************************************************************
Function
do_barb_grid(Begins at: 10, Ends at:165)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 24 | ** | BABY-MONSTER | 24 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 43 | ** | BABY-MONSTER | 43 |
LOC: | 156 | ** | BABY-MONSTER | 156 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/main.c
*****************************************************************
Function
main(Begins at: 26, Ends at:253)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | * | WARNING | 19 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 83 | *** | MONSTER | 83 |
LOC: | 228 | *** | MONSTER | 228 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/display/d.barb/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/display/d.barb/legend.c
*****************************************************************
Function
do_legend(Begins at: 8, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 58 | | OK | 58 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Wed Mar 23 17:52:38 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 21 | 33 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 16 | 38 | 61 |
LOC: | 64 | 145 | 226 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list