# [GRASS-QA] GRASS QA: hamish |points.c draw.c | no clones | 3 monsters |1 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu Mar 24 17:45:02 EDT 2011

```Hello hamish,

here's a report on your recent grass-SVN change for the revision : 45745

ANALYSIS

*****************************************************************
File :/display/d.barb/points.c
*****************************************************************

Function
fill_arrays(Begins at: 155, Ends at:270)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |     * |      WARNING |        19 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      36 |     * |      WARNING |        36 |
LOC:          |     116 |     * |      WARNING |       116 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

do_barb_points(Begins at: 10, Ends at:106)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      26 |     * |      WARNING |        26 |
LOC:          |      97 |     * |      WARNING |        97 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
File :/display/d.barb/draw.c
*****************************************************************

Function
draw_feather(Begins at: 206, Ends at:376)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |     187 |   *** |      MONSTER |       187 |
LOC:          |     171 |    ** | BABY-MONSTER |       171 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

draw_circle(Begins at: 166, Ends at:200)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      16 |     * |      WARNING |        16 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

Clone analysis:
This file does not contain cloned functions

____________________________________________

Threshold grass key metrics values at Thu Mar 24 17:44:51 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning   | middle    | extrem    |
| limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        16 |        38 |        61 |
LOC:                  |        64 |       145 |       226 |
----------------------+-----------+-----------+-----------+

Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
OK : Nothing to say at all
*  : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function

Conclusion interpretation :
CORRECT     : if all metrics are situated before warning limits
WARNING     : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS    : if 1 to more metrics are in the extreme limits

_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory