[GRASS-QA] GRASS QA: mmetz |lidar.h zones.c | 4 clones | 0 monsters
|4 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed May 4 03:45:55 EDT 2011
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 46176
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/lidar/lidar.h
*****************************************************************
Class
Point(Begins at: 79, Ends at:86)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Reg_dimens(Begins at: 70, Ends at:77)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
element(Begins at: 88, Ends at:93)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/lidar/zones.c
*****************************************************************
Function
P_get_edge(Begins at: 187, Ends at:205)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
P_set_dim(Begins at: 119, Ends at:184)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
P_Read_Vector_Region_Map(Begins at: 309, Ends at:374)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
P_Read_Raster_Region_Map(Begins at: 376, Ends at:451)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 76 | * | WARNING | 76 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file has 4 potentially cloned functions:
P_set_dim P_Read_Vector_Region_Map P_Read_Raster_Region_Map
In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_get_edge are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c P_get_edge
In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_set_dim are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c P_set_dim
In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Read_Vector_Region_Map are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c P_Read_Vector_Region_Map
In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Read_Raster_Region_Map are:
/data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c P_Read_Raster_Region_Map
____________________________________________
Threshold grass key metrics values at Wed May 04 03:45:36 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 65 | 147 | 230 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list