[GRASS-QA] GRASS QA: mmetz |resamp.c | 5 clones | 1 monsters |3 warnings

[soccerlab.info at gmail.com]

Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 46278 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/vector/v.surf.bspline/resamp.c
*****************************************************************

          Function
P_Read_Raster_Region_masked(Begins at: 27, Ends at:111)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |     * |      WARNING |        14 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      85 |     * |      WARNING |        85 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


P_Sparse_Raster_Points(Begins at: 113, Ends at:225)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |      15 |   *** |      MONSTER |        15 |
CalledNBR:    |      11 |       |           OK |        11 |
LOC:          |     113 |     * |      WARNING |       113 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


align_elaboration_box(Begins at: 229, Ends at:274)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      46 |       |           OK |        46 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


align_interp_boxes(Begins at: 280, Ends at:399)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |     120 |     * |      WARNING |       120 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 5 potentially cloned functions:
  align_elaboration_box  align_elaboration_box  align_interp_boxes  align_interp_boxes

In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/resamp.c clones of P_Sparse_Raster_Points are:
          /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/resamp.c  P_Sparse_Raster_Points

In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/resamp.c clones of align_elaboration_box are:
          /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/resamp.c  align_elaboration_box
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/resamp.c  align_elaboration_box

In /data/project-manager/grass/grassSVN/grass/trunk/vector/v.surf.bspline/resamp.c clones of align_interp_boxes are:
          /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/resamp.c  align_interp_boxes
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/resamp.c  align_interp_boxes

____________________________________________


Threshold grass key metrics values at Sat May 14 13:41:56 EDT 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        64 |       145 |       226 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html