[GRASS-QA] GRASS QA: mmetz |Gs3.c | 5 clones | 0 monsters |6 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Sun May 22 13:27:19 EDT 2011
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 46347
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/ogsf/Gs3.c
*****************************************************************
Function
Gs_loadmap_as_short(Begins at: 313, Ends at:390)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 78 | * | WARNING | 78 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Gs_loadmap_as_int(Begins at: 179, Ends at:220)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 42 | | OK | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Gs_loadmap_as_bitmap(Begins at: 518, Ends at:563)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 16 | | OK | 16 |
LOC: | 46 | | OK | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Gs_loadmap_as_char(Begins at: 418, Ends at:497)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 18 | * | WARNING | 18 |
LOC: | 80 | * | WARNING | 80 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Gs_get_cat_label(Begins at: 777, Ends at:840)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 25 | * | WARNING | 25 |
LOC: | 64 | * | WARNING | 64 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Gs_loadmap_as_float(Begins at: 115, Ends at:157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 15 | | OK | 15 |
LOC: | 43 | | OK | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 5 potentially cloned functions:
Gs_loadmap_as_int Gs_loadmap_as_bitmap Gs_loadmap_as_char Gs_loadmap_as_float
In /data/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c clones of Gs_loadmap_as_short are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c Gs_loadmap_as_short
In /data/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c clones of Gs_loadmap_as_int are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c Gs_loadmap_as_int
In /data/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c clones of Gs_loadmap_as_bitmap are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c Gs_loadmap_as_bitmap
In /data/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c clones of Gs_loadmap_as_char are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c Gs_loadmap_as_char
In /data/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c clones of Gs_loadmap_as_float are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/Gs3.c Gs_loadmap_as_float
____________________________________________
Threshold grass key metrics values at Sun May 22 13:27:08 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 21 | 33 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 64 | 146 | 228 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list