[GRASSLIST:4681] Re: s.surf.krig

[Glynn Clements]

Dylan Beaudette wrote:

> > > is there anyway to compile this specific program, and install it? I have
> > > tried gmake53 in the s.surf.krig folder, but it gives me a bunch of
> > > errors...
> >
> > What are the errors?
> > Did you install blas and lapack before you compiled GRASS (and add those
> > options to the configure script)? They are pre-requisites but I'm sure
> > there are other problems with s.surf.krig.
> 
> After searching about a bit i found that gmake53 -i in the src directory is 
> the command to use. However it gives the following errors:
> 
> -------------------------------------------------
> dylan at basho:~/src/grass53_exp_2004_10_23/src/sites/s.surf.krig$ gmake53 -i

> main.c: In function `main':
> main.c:360: error: void value not ignored as it ought to be
> main.c:366: error: void value not ignored as it ought to be

> I cannot see anysyntax errors at the lines 360 or 366 in main.c ... but then 
> again i am not a C expert...

G_set_null_value() doesn't return anything. I've fixed it in CVS, or
you can apply the attached patch.

However, the nature of the error suggests that s.surf.krig hasn't been
touched for some time, so there may well be other errors.

-- 
Glynn Clements <glynn at gclements.plus.com>

-------------- next part --------------
Index: src/sites/s.surf.krig/main.c
===================================================================
RCS file: /grassrepository/grass/src/sites/s.surf.krig/main.c,v
retrieving revision 1.3
diff -u -r1.3 main.c
--- src/sites/s.surf.krig/main.c	26 Nov 2000 17:20:04 -0000	1.3
+++ src/sites/s.surf.krig/main.c	29 Oct 2004 03:28:24 -0000
@@ -357,17 +357,10 @@
 
       if (mask && mask[col] == 0)
       {				/* don't interpolate outside of the mask */
-	if( G_set_null_value(cell1, 1, DCELL_TYPE) < 0 ) {
-	  fprintf(stderr, "Failed to assign raster cell value\n");
-	  exit(1);  /* raster map of value z */
-	}
+	G_set_null_value(cell1, 1, DCELL_TYPE);
 	cell1++;
 
-	if( G_set_null_value(cell2, 1, DCELL_TYPE) < 0 ) {
-	  fprintf(stderr, "Failed to assign raster cell value\n");
-	  exit(1);  /* raster map of the 
-		       var. of value z */
-	}
+	G_set_null_value(cell2, 1, DCELL_TYPE);
 	cell2++;
       }
       else