<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 21/09/2010 10:00, Glynn Clements wrote:
<blockquote
cite="mid:19608.26137.495562.184843@cerise.gclements.plus.com"
type="cite">
<pre wrap="">Luigi Ponti wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Any ideas? A change introduced in 6.4.0-1 has rendered WinGRASS
unusable to me [...]
</pre>
</blockquote>
<pre wrap="">
[...] is there a way to compile the code
in the state it was before the issue arose?
</pre>
</blockquote>
<pre wrap=""><!---->
You can prevent the error with:
--- vector/v.in.ascii/in.c~        2010-09-04 16:31:59.000000000 +0100
+++ vector/v.in.ascii/in.c        2010-09-21 08:57:12.000000000 +0100
@@ -519,8 +519,7 @@
        if (driver) {
         G_message(_("Populating table..."));
         db_commit_transaction(driver);
-         if(db_close_database_shutdown_driver(driver) == DB_FAILED)
-                G_fatal_error(_("Could not close attribute table. The DBMI driver did not accept all attributes"));
+         db_close_database_shutdown_driver(driver);
        }
        fclose(tmpascii);
}
db_close_database_shutdown_driver() is incorrectly reporting errors on
Windows. v.in.ascii is the only module which checks the return status,
so it's the only module which is affected.
</pre>
</blockquote>
<br>
Implemented your patch to changeset 4359 releasebranch_6_4, compiled
following instructions at
<a class="moz-txt-link-rfc2396E" href="http://trac.osgeo.org/grass/wiki/CompileOnWindows"><http://trac.osgeo.org/grass/wiki/CompileOnWindows></a>, and it works
for the following simple test (see
<a class="moz-txt-link-rfc2396E" href="http://trac.osgeo.org/grass/ticket/1159#comment:13"><http://trac.osgeo.org/grass/ticket/1159#comment:13></a>):<br>
<br>
<blockquote>GRASS 6.4> echo "10|10|abcd" | v.in.ascii out=test<br>
Scanning input for column types...<br>
Maximum input row length: 11<br>
Maximum number of columns: 3<br>
Minimum number of columns: 3<br>
Column: 1 type: double<br>
Column: 2 type: double<br>
Column: 3 type: string length: 4<br>
Importando punti ...<br>
100%<br>
Populating table...<br>
Building topology for vector map <test>...<br>
Registering primitives...<br>
1 primitives registered<br>
1 vertices registered<br>
Building areas...<br>
100%<br>
0 areas built<br>
0 isles built<br>
Attaching islands...<br>
Attaching centroids...<br>
100%<br>
Number of nodes: 1<br>
Number of primitives: 1<br>
Number of points: 1<br>
Number of lines: 0<br>
Number of boundaries: 0<br>
Number of centroids: 0<br>
Number of areas: 0<br>
Number of isles: 0<br>
v.in.ascii completo.<br>
</blockquote>
<br>
The point can be displayed, and the dbf table seems ok. Also works
using a longer sample text file I previously linked<br>
<a class="moz-txt-link-freetext" href="https://docs.google.com/leaf?id=0B0EpsfMZ-IZYNGZlNWZkMWEtNzhiNS00OGRiLTgyNzctYzk4ODUxODk1NzI1&sort=name&layout=list&num=50">https://docs.google.com/leaf?id=0B0EpsfMZ-IZYNGZlNWZkMWEtNzhiNS00OGRiLTgyNzctYzk4ODUxODk1NzI1&sort=name&layout=list&num=50</a><br>
<br>
<blockquote>GRASS 6.4> v.in.ascii --overwrite
input=Bloomday_Olive_11set10_Avg output=test_US_import fs=tab<br>
ATTENZIONE: Vector map <test_US_import> already exists and will be<br>
overwritten<br>
Scanning input for column types...<br>
Maximum input row length: 31<br>
Maximum number of columns: 3<br>
Minimum number of columns: 3<br>
Column: 1 type: double<br>
Column: 2 type: double<br>
Column: 3 type: double<br>
Importando punti ...<br>
100%<br>
Populating table...<br>
Building topology for vector map <test_US_import>...<br>
Registering primitives...<br>
1157 primitives registered<br>
1157 vertices registered<br>
Building areas...<br>
100%<br>
0 areas built<br>
0 isles built<br>
Attaching islands...<br>
Attaching centroids...<br>
100%<br>
Number of nodes: 1154<br>
Number of primitives: 1157<br>
Number of points: 1157<br>
Number of lines: 0<br>
Number of boundaries: 0<br>
Number of centroids: 0<br>
Number of areas: 0<br>
Number of isles: 0<br>
v.in.ascii completo.<br>
</blockquote>
<br>
I am not sure as to whether this should be reported on
<a class="moz-txt-link-rfc2396E" href="http://trac.osgeo.org/grass/ticket/1159"><http://trac.osgeo.org/grass/ticket/1159></a>.<br>
<br>
Related ticket 1158 <a class="moz-txt-link-rfc2396E" href="http://trac.osgeo.org/grass/ticket/1158"><http://trac.osgeo.org/grass/ticket/1158></a>
seems to persist:<br>
<br>
<blockquote>GRASS 6.4> v.in.ascii --overwrite
input=C:/cygwin/home/andy/models_temp/Bloomd<br>
ay_Olive_11set10_Avg output=test_US_import fs=tab<br>
ATTENZIONE: Vector map <test_US_import> already exists and will be<br>
overwritten<br>
ATTENZIONE: Unable to delete file<br>
'C:\cygwin\home\andy/latlong/luigi/vector/test_US_import/hist'<br>
ERRORE: Unable to delete vector map <test_US_import><br>
</blockquote>
<br>
Still not entirely clear to me which variable I am supposed to set in
order to get full English messages.<br>
<br>
Thanks and regards,<br>
<br>
Luigi<br>
<br>
<br>
<br>
</body>
</html>