[Incubator] istSOS incubation

Mon Jun 24 14:34:07 PDT 2019

That checklist looks good, for Providence review it has the following:

*[x] Provenance Review (All code has been developed by the registered
developers listed on github who have signed the CLA. All external libraries
have project compatible licenses. The project has been started as a regular
Open Source project following the guidelines as set out by OSGeo. A
file-per-file code review was therefore deemed superfluous.)*

This was a really well done codebase to review and look at - nice work :)

Do you have a link to the providence review? Like if I look at the codebase
in GitHub I can quickly find:
- LICENSE.md
<https://github.com/oskariorg/oskari-server/blob/master/LICENSE.md> file
links to EUPL v1.1
<https://joinup.ec.europa.eu/software/page/eupl/licence-eupl>, but this
license (which was news to me) as some details on what must be included in
each distribution, can you say how they are being met?
- one of the distributions appears to be generation of a WAR
<https://github.com/oskariorg/oskari-server/blob/master/webapp-setup/pom.xml#L12>
in
webapp-setup, this would be an example where the above LICENSE details
should be included?
- when I quickly looked at java files none of them had
<https://github.com/oskariorg/oskari-server/blob/76b78cacfddc39800f4d3af35df8760d096b5737/control-userlayer/src/main/java/org/oskari/control/userlayer/CreateUserLayerHandler.java>
a
<https://github.com/oskariorg/oskari-server/blob/76b78cacfddc39800f4d3af35df8760d096b5737/control-routing/src/main/java/fi/nls/oskari/control/routing/RoutingHandler.java>
header
<https://github.com/oskariorg/oskari-server/blob/76b78cacfddc39800f4d3af35df8760d096b5737/servlet-map/src/main/java/fi/nls/oskari/spring/OskariRequestInterceptor.java>
indicating copyright and license. Can you talk us through why you made this
decision?
- looking at a specific example WebappHelper
<https://github.com/oskariorg/oskari-server/blob/76b78cacfddc39800f4d3af35df8760d096b5737/service-webapp/src/main/java/fi/nls/oskari/servlet/WebappHelper.java>
(that
looked generic) I see the user "SMAKINEN" does not appear similar to any
contributors listed in the file commit history
<https://github.com/oskariorg/oskari-server/commits/76b78cacfddc39800f4d3af35df8760d096b5737/service-webapp/src/main/java/fi/nls/oskari/servlet/WebappHelper.java>
 ....
/**
 * Created by SMAKINEN on 8.7.2015.
 */
public class WebappHelper {

- properties file may be considered executable code, do you want a header
indicating license?
- I was impressed to see header preserved when building off of prior work
<https://github.com/oskariorg/oskari-server/blob/76b78cacfddc39800f4d3af35df8760d096b5737/geoserver-ext/OskariMarkFactory/src/main/java/org/geotools/renderer/oskari/TTFMarkFactoryOskari.java>,
but that ends up confusing when you do not have a header of your own ...
- various build files, example pom.xml
<https://github.com/oskariorg/oskari-server/blob/master/pom.xml>, lack
copyright license details (you may not care since they do not form
executable code)

The incubation committee here is go through the same kind of steps a
potential contributor would go through.This is the first time I have found
a project without headers making me not quite sure how to review ...

--
Jody Garnett

On Mon, 24 Jun 2019 at 19:38, Jody Garnett <jody.garnett at gmail.com> wrote:

> Oh that is my bad, got the subject wrong :(
> --
> Jody Garnett
>
>
> On Mon, 24 Jun 2019 at 14:31, Aarnio Timo (MML) <
> timo.aarnio at maanmittauslaitos.fi> wrote:
>
>> Hi Jody&al!
>>
>>
>>
>> Thank you for helping, the revised checklist page can be found here:
>>
>> https://github.com/oskariorg/oskari-docs/wiki/Oskari-Incubation-Checklist
>>
>> (and the old one is still here:)
>> https://wiki.osgeo.org/wiki/Oskari_Incubation_Status
>>
>>
>>
>> Please let us know how it looks and if there is something we can clarify
>> or improve.
>>
>>
>>
>> BR,
>>
>> Timo
>>
>>
>>
>> PS. I did not realize your previous message dated May 27th, the subject
>> esp. with the preview of the body text got me thinking it’s unrelated,
>> sorry!
>>
>>
>>
>> *From:* Jody Garnett <jody.garnett at gmail.com>
>> *Sent:* perjantai 21. kesäkuuta 2019 19.50
>> *To:* OSGeo-incubator <incubator at lists.osgeo.org>; Massimiliano Cannata <
>> massimiliano.cannata at supsi.ch>; Aarnio Timo (MML) <
>> timo.aarnio at maanmittauslaitos.fi>
>> *Subject:* Re: istSOS incubation
>>
>>
>>
>> Any progress on a revised checklist page?
>>
>> --
>>
>> Jody Garnett
>>
>>
>>
>>
>>
>> On Tue, 28 May 2019 at 12:53, Jody Garnett <jody.garnett at gmail.com>
>> wrote:
>>
>> I am taking this into a separate thread, thanks everyone for
>> communicating across all the delays.
>>
>>
>>
>> For the specific topic on open community and communication, it is my hope
>> you already meet this requirement but to answer I would need ask how the
>> project functions. My personal request is you write down how the
>> communication works now, and do not set a goal as it may not be needed.
>>
>>
>>
>> You can take inspiration from other projects that completed gradation
>> <https://wiki.osgeo.org/wiki/Incubation_Committee#Graduated> and how
>> they filled in this section.
>>
>>
>>
>> *open communication*: The key is "public" communication, but can be a
>> shared chat channel, or active stack exchange (email was common when open
>> source started but is less common now). There are reasons to have private
>> communication channels (GeoServer has a private security email list but we
>> do document that it exists and committers can be included if they are in a
>> position to help fix vulnerabilities). For a quick check I look at the repo
>> README.
>>
>>
>>
>> *open community:* Another aspect is that people can join the project and
>> join the project leadership.We want to avoid the "single dictator" model as
>> that is brittle. For a quick check I look at a repo CONTRIBTING.md.
>>
>>
>>
>> The checklist should be in a place where your team collaborates (a place
>> they all have permission to edit):
>>
>> - If you use GitHub there is a markdown copy here
>> <https://github.com/OSGeo/osgeo/tree/master/incubation/documents> to
>> take into your wiki
>>
>> - If you use OSGeo wiki copy one of the other examples
>>
>> - If you use your own wiki or something that is also fine
>>
>>
>>
>> When you and your mentor are happy the mentor will nominate the project
>> and share the checklist. You are also welcome to share as you write and ask
>> questions about difficult sections.
>>
>>
>>
>> And I do not want the incubation sprint planning to get lost in this
>> discussion, when you have a date Maxi there are several options for funding.
>>
>> --
>>
>> Jody Garnett
>>
>>
>>
>> Dear Jody and Incubator-list,
>>
>> Indeed, we’re still very interested in graduating as full members. Last
>> time we had communications (On 24/8/18 12:46 am ) left us a bit waiting for
>> answers to our questions, the most important probably being:
>>
>> “What kind of concrete indicators would you like to see [that we have ‘an
>> open community and communication’]? What could be a good goal?”
>>
>> I.e. what could we do as a community in order for it to be more open? One
>> thing contributing to that comes to mind (from the top of my head): We’ve
>> since changed from Slack to the open-for-everyone-without-invitations
>> Gitter (https://gitter.im/oskariorg/chat). AFAIK Gitter stores chat
>> history indefinitely, which is a good thing. The PSC-memos are on GitHub
>> and some of the discussion is on the mailing list.
>>
>> As for the graduation checklist, unfortunately I can’t find information
>> where it should be filled. The website
>> https://www.osgeo.org/resources/project-graduation-checklist/has a
>> downloadable PDF which is probably the one that should be filled?
>>
>> Most of the information required is probably already here
>> https://wiki.osgeo.org/wiki/Oskari_Incubation_Status but we’d be happy
>> to fill the new one.
>>
>> So, can you please point us to a list we can fill? Do we send it back to
>> this list then?
>>
>> Many thanks in advance!
>>
>>
>> - Timo
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/incubator/attachments/20190624/bbe3ad6e/attachment.html>