[Incubator] Application for Community Project Status for the mappyfile project

Wed Sep 9 06:27:35 PDT 2020

Looks fine, and the real benefit is you are aware of and are respecting the
open source licenses.
In the future you may find it advantageous to use "Copyright (c) 2020 Seth
Girvin and others" for files like this.

If that is the last thing can we resume reviewing mappyfile project for the
osgeo community program?
--
Jody Garnett

On Wed, 9 Sep 2020 at 04:42, Seth G <sethg at geographika.co.uk> wrote:

> Hi Jody,
>
> Thanks for getting back on this.
> I added attribution as best I could to the top of the file in question -
> https://github.com/geographika/mappyfile/blob/master/mappyfile/ordereddict.py#L3
> Not sure if there is much else I can do beyond this?
>
> Seth
>
> --
> web:http://geographika.co.uk
> twitter: @geographika
>
>
> On Wed, Sep 9, 2020, at 7:22 AM, Jody Garnett wrote:
>
> Did you ever finish sorting out your code providence review?
> --
> Jody Garnett
>
>
> On Fri, 14 Feb 2020 at 14:33, Seth G <sethg at geographika.co.uk> wrote:
>
>
> Hi Jody,
>
> Thanks for the feedback.
>
>
>    - I've updated the logo based on the provided image size, and with a
>    white background. I'm not sure it looks better with the white background,
>    but admittedly it isn't much of a logo!
>    - I tried the laptop border with a different screenshot, but it was
>    too small to be legible, so I've left as is.
>    - I think the Facebook row was added by default? I've removed and
>    added my Twitter account, which I use to mention new releases of the
>    project (although it is not a project specific account - so not sure if it
>    should be included?).
>
>
> With regard to copyright I noticed a few different styles:
>
> - Short copyright header e.g. in pywps:
> https://github.com/geopython/pywps/blob/master/pywps/configuration.py
> - Full copyright header: e.g. in pygeoapi:
> https://github.com/geopython/pygeoapi/blob/master/tests/load_es_data.py
> - No copyright header: e.g. in Shapely
> https://github.com/Toblerity/Shapely/blob/master/shapely/coords.py
>
> I went with the full header (a few of the source files have joint
> authorship), but only on the sourcecode *.py files, not on all the test
> files. Does join authorship imply joint copyright? Or if the second author
> agrees can it be a single copyright?
>
> While reviewing the authorship I have run into something I'm unsure how to
> best deal with. The file
> https://github.com/geographika/mappyfile/blob/master/mappyfile/ordereddict.py
> is based on an implementation of an OrderedDict from StackOverflow which is
> in turn based on another piece of code on the web. I found the authors
> names and added them to the header (and already had links to the
> implementations). The code has since been modified by myself a few times,
> and is a fairly standard way of implementing OrderedDicts, but I did use
> their approach as a starting point.
> Is there anything I have to do in this case?
>
> Regards,
>
> Seth
>
>
> --
> web:http://geographika.co.uk
> twitter: @geographika
>
>
> On Fri, Feb 14, 2020, at 1:07 PM, Jody Garnett wrote:
>
> Very quickly, thanks for your email!
>
> We want to make sure you have checked you have the permission to
> distribute each file (either wrote it yourself or a contributor agreed to
> make it open source). We have found in our research that having a copyright
> header is not a legal requirement, but it is a smart thing to do socially
> (for folks that discover your code via searching).
>
> Your project page is one of the best first attempts we have seen here,
> some feedback:
> - please make sure that your logo is placed on a white background (the
> sample image size is here
> <https://www.osgeo.org/wp-content/uploads/template_tile.png>). Without
> this it looks bad when displayed in a list or at the top of the page on a
> green background.
> - your diagram is very interesting, but I am not sure if it is a screen
> snap or not? We have a border here
> <https://github.com/OSGeo/osgeo/tree/master/marketing/photos> to provide
> a laptop frame
> - you have a link to Facebook, but it does not go anywhere (but perhaps
> that is an issue with the preview)
>
> --
> Jody Garnett
>
>
> On Fri, 14 Feb 2020 at 00:11, Seth G <sethg at geographika.co.uk> wrote:
>
> Hi all,
>
> I'd like to apply for OSGeo Community Project status for the mappyfile
> project. mappyfile is a Python library to create, parse, modify, and format
> MapServer Mapfiles.
>
> It has been around for 3 years, with continuous development and
> contributions, and is used as a library in several public projects (see
> [1]), and many more non-public projects. It was first presented at
> FOSS4G-Europe (Paris) in 2017 (see slides at [2]). I've gone through the
> criteria listed on the OSGeo site [3] and added links and details below:
>
> - Be geospatial
>
>   - mappyfile is a Python parser for working with MapServer MapFiles
>   - User docs at https://mappyfile.readthedocs.io/en/latest/
>   - ReadMe at
> https://github.com/geographika/mappyfile/blob/master/README.rst
>   - Is included in OSGeoLive (see [4])
>   - Is included in ubuntugis-stable (package archive) [5]
>   - I've created a draft project page on https://www.osgeo.org/ - see [6]
>
> - Have a free licence or an open source licence
>
>   - Uses the MIT Licence:
> https://github.com/geographika/mappyfile/blob/master/LICENSE
>   - I'm unsure if each individual .py file requires a copyright header
>
> - Welcome participation and new contributors.
>
>   - Has a small community of contributors see:
> https://github.com/geographika/mappyfile/graphs/contributors
>   - Has a contribution policy:
> https://github.com/geographika/mappyfile/blob/master/CONTRIBUTING.md
>   - Has a code of conduct:
> https://github.com/geographika/mappyfile/blob/master/code-of-conduct.md
>
> I'm happy to answer any questions on the project, and please let me know
> what other criteria need to be met to apply for community project status
> (as noted above I'm unsure if each individual file requires a copyright
> header).
>
> Regards,
>
> Seth
>
> [1] https://github.com/geographika/mappyfile/network/dependents
> [2]
> https://github.com/geographika/mappyfile/blob/master/docs/_static/foss4ge2017_mappyfile_sgirvin.pdf
> [3]
> https://wiki.osgeo.org/wiki/OSGeo_Community_Projects#Qualifying_As_An_OSGeo_Community_Project
> [4]
> https://github.com/OSGeo/OSGeoLive/commit/2df427d7744fc2adc0e9889af7a8f6c80dd9c11b
> [5] https://launchpad.net/~ubuntugis/+archive/ubuntu/ppa
> [6] https://www.osgeo.org/?post_type=project&p=12880&preview=true
>
>
> --
> web:http://geographika.co.uk
> twitter: @geographika
> _______________________________________________
> Incubator mailing list
> Incubator at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/incubator
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/incubator/attachments/20200909/03032cf9/attachment.html>