[Liblas-commits] hg-main-tree: vs2010 lint

liblas-commits at liblas.org liblas-commits at liblas.org
Wed Jun 22 13:36:40 EDT 2011


details:   http://hg.libpc.orghg-main-tree/rev/2819deecf9c9
changeset: 801:2819deecf9c9
user:      Michael P. Gerlek <mpg at flaxen.com>
date:      Wed Jun 22 10:34:57 2011 -0700
description:
vs2010 lint

diffstat:

 src/drivers/qfit/Reader.cpp  |  4 ++++
 test/unit/QFITReaderTest.cpp |  4 ++--
 test/unit/TerraSolidTest.cpp |  2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diffs (47 lines):

diff -r c4edb940f08f -r 2819deecf9c9 src/drivers/qfit/Reader.cpp
--- a/src/drivers/qfit/Reader.cpp	Wed Jun 22 10:24:20 2011 -0700
+++ b/src/drivers/qfit/Reader.cpp	Wed Jun 22 10:34:57 2011 -0700
@@ -177,6 +177,10 @@
 #include <iostream>
 #include <map>
 
+#ifdef PDAL_COMPILER_MSVC
+#  pragma warning(disable: 4127)  // conditional expression is constant
+#endif
+
 namespace pdal { namespace drivers { namespace qfit {
 
 PointIndexes::PointIndexes(const Schema& schema, QFIT_Format_Type format)
diff -r c4edb940f08f -r 2819deecf9c9 test/unit/QFITReaderTest.cpp
--- a/test/unit/QFITReaderTest.cpp	Wed Jun 22 10:24:20 2011 -0700
+++ b/test/unit/QFITReaderTest.cpp	Wed Jun 22 10:34:57 2011 -0700
@@ -109,7 +109,7 @@
     
     {
         boost::uint32_t numRead = iter->read(data);
-        BOOST_CHECK_EQUAL(numRead,3);
+        BOOST_CHECK_EQUAL(numRead,3u);
     }
 
     delete iter;
@@ -143,7 +143,7 @@
     
     {
         boost::uint32_t numRead = iter->read(data);
-        BOOST_CHECK_EQUAL(numRead,3);
+        BOOST_CHECK_EQUAL(numRead,3u);
     }
 
     delete iter;
diff -r c4edb940f08f -r 2819deecf9c9 test/unit/TerraSolidTest.cpp
--- a/test/unit/TerraSolidTest.cpp	Wed Jun 22 10:24:20 2011 -0700
+++ b/test/unit/TerraSolidTest.cpp	Wed Jun 22 10:34:57 2011 -0700
@@ -111,7 +111,7 @@
     
     {
         boost::uint32_t numRead = iter->read(data);
-        BOOST_CHECK_EQUAL(numRead,3);
+        BOOST_CHECK_EQUAL(numRead,3u);
     }
 
     delete iter;


More information about the Liblas-commits mailing list