[Liblas-devel] preprocessor symbols in public headers

[Howard Butler]

On Jan 18, 2011, at 7:47 PM, Ed Hill wrote:

> 
> 
> Hi folks,
> 
> I'm trying to get libLAS packaged and included with Fedora & EPEL:
> 
>  https://bugzilla.redhat.com/show_bug.cgi?id=666301
> 
> and I've run into an issue involving the headers.  Basically, a fairly
> standard build and install results in a few of the public headers
> containing preprocessor symbols such as:
> 
>  #ifdef HAVE_GDAL
>  #ifdef HAVE_LASZIP

Ed,

This is a habit that I acquired from GDAL and MapServer, which have HAVE_'s all over the place (and are both in the Fedora tree).  

I also agree they shouldn't be in the public headers and we should clean them up.  I have removed the HAVE_GDAL's from transform.hpp already, and will try to get to the HAVE_LASZIP ones tomorrow.

Howard