[Liblas-devel] libLAS 1.2.1 getting color by random access

[Howard Butler]

On Jan 18, 2011, at 3:56 PM, Volker Wichmann wrote:

> Hi,
> 
> I think there is a bug in libLAS 1.2.1 when retrieving point color by random access (green and blue are interchanged), reader12.cpp, line 334 ff:
> 
> detail::read_n(red, m_ifs, sizeof(uint16_t));
> detail::read_n(blue, m_ifs, sizeof(uint16_t));
> detail::read_n(green, m_ifs, sizeof(uint16_t));
> 
> I think this should read as
> 
> detail::read_n(red, m_ifs, sizeof(uint16_t));
> detail::read_n(green, m_ifs, sizeof(uint16_t));
> detail::read_n(blue, m_ifs, sizeof(uint16_t));
> 
> The same applies for lines 347 ff.
> 
> 

Volker,

I have confirmed this is fixed in libLAS 1.6.0b4 (we no longer read fields this way either).

If you are interested, I could give you Mercurial push access if you feel the need to continue to maintain a 1.2.x branch of libLAS.  I do not have the resources to keep applying patches there, but I can understand if others would like to keep it alive for the time being.

Howard