svn commit: r239 - trunk/mapbender/http/php/mod_filteredUser_Group.php

uli at osgeo.org uli at osgeo.org
Thu May 11 06:14:49 EDT 2006


Author: uli
Date: 2006-05-11 10:14:49+0000
New Revision: 239

Modified:
   trunk/mapbender/http/php/mod_filteredUser_Group.php

Log:
db_prep_query included
verification of user permissions

Modified: trunk/mapbender/http/php/mod_filteredUser_Group.php
Url: https://mapbender.osgeo.org/source/browse/mapbender/trunk/mapbender/http/php/mod_filteredUser_Group.php?view=diff&rev=239&p1=trunk/mapbender/http/php/mod_filteredUser_Group.php&p2=trunk/mapbender/http/php/mod_filteredUser_Group.php&r1=238&r2=239
==============================================================================
--- trunk/mapbender/http/php/mod_filteredUser_Group.php	(original)
+++ trunk/mapbender/http/php/mod_filteredUser_Group.php	2006-05-11 10:14:49+0000
@@ -18,12 +18,11 @@
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 
 import_request_variables("PG");
-session_start();
-require_once("../php/mb_validateSession.php");
 require_once("../../conf/mapbender.conf");
-$con = db_connect($DBSERVER,$OWNER,$PW);
+$con = db_connect(DBSERVER,OWNER,PW);
 db_select_db(DB,$con);
-$gui_id = $_SESSION["mb_user_gui"];
+require_once("../php/mb_validatePermission.php");
+$self = $PHP_SELF . "?".SID."&guiID=".$_REQUEST["guiID"]."&elementID=".$_REQUEST["elementID"];
 ?>
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
@@ -37,8 +36,8 @@
 <script language="JavaScript">
 function validate(wert){
 	if(document.forms[0]["selected_user"].selectedIndex == -1){
-			document.getElementsByName("selected_user")[0].style.backgroundColor = '#ff0000';
-			return;
+		document.getElementsByName("selected_user")[0].style.backgroundColor = '#ff0000';
+		return;
 	}else{
 		if(wert == "remove"){
 			if(document.forms[0]["remove_group[]"].selectedIndex == -1){
@@ -63,10 +62,6 @@
 </head>
 <body>
 <?php
-require_once("../../conf/mapbender.conf");
-$con = db_connect($DBSERVER,$OWNER,$PW);
-db_select_db(DB,$con);
-
 
 $fieldHeight = 20;
 
@@ -79,17 +74,21 @@
 $logged_user_name=$_SESSION["mb_user_name"];
 $logged_user_id=$_SESSION["mb_user_id"];
 
-/*handle remove, update and insert**************************************************************************************/
+/*handle remove, update and insert*****************************************************************/
 if($insert){
 	if(count($selected_group)>0){
 		for($i=0; $i<count($selected_group); $i++){
 			$exists = false;
-			$sql_insert = "SELECT * from mb_user_mb_group where fkey_mb_user_id = '".$selected_user."' and fkey_mb_group_id = '".$selected_group[$i]."'";
-			$res_insert = db_query($sql_insert);
+			$sql_insert = "SELECT * from mb_user_mb_group where fkey_mb_user_id = $1 and fkey_mb_group_id = $2";
+			$v = array($selected_user,$selected_group[$i]);
+			$t = array('i','i');
+			$res_insert = db_prep_query($sql_insert,$v,$t);
 			while(db_fetch_row($res_insert)){$exists = true;}
 			if($exists == false){
-				$sql_insert = "INSERT INTO mb_user_mb_group(fkey_mb_user_id, fkey_mb_group_id) VALUES('$selected_user', '".$selected_group[$i]."');";
-				$res_insert = db_query($sql_insert);
+				$sql_insert = "INSERT INTO mb_user_mb_group(fkey_mb_user_id, fkey_mb_group_id) VALUES($1, $2)";
+				$v = array($selected_user,$selected_group[$i]);
+				$t = array('i','i');
+				$res_insert = db_prep_query($sql_insert,$v,$t);
 			}
 		}
 	}
@@ -97,20 +96,16 @@
 if($remove){
 	if(count($remove_group)>0){
 		for($i=0; $i<count($remove_group); $i++){
-			$sql_remove = "DELETE FROM mb_user_mb_group WHERE fkey_mb_group_id = '".$remove_group[$i]."' and fkey_mb_user_id = '$selected_user'";
-			db_query($sql_remove);
+			$sql_remove = "DELETE FROM mb_user_mb_group WHERE fkey_mb_group_id = $1 and fkey_mb_user_id = $2";
+			$v = array($remove_group[$i],$selected_user);
+			$t = array('i','i');
+			db_prep_query($sql_remove,$v,$t);
 		}
 	}
 }
 
-/*get all groups  ********************************************************************************************/
+/*get all groups  *********************************************************************************/
 $sql_group = "SELECT * FROM mb_group ORDER BY mb_group_name";
-#$sql_group = "SELECT * FROM mb_group WHERE mb_group_owner='".$logged_user_id."' ORDER BY mb_group_name";
-
-/*get allocated groups  ********************************************************************************************/
-#$sql_group = "SELECT mb_group.mb_group_id, mb_group.mb_group_name, mb_user_mb_group.fkey_mb_user_id ";
-#$sql_group .= "FROM mb_group INNER JOIN mb_user_mb_group ON mb_group.mb_group_id = mb_user_mb_group.fkey_mb_group_id ";
-#$sql_group .= "WHERE mb_user_mb_group.fkey_mb_user_id='".$logged_user_id."'";
 
 $res_group = db_query($sql_group);
 while($row = db_fetch_array($res_group)){
@@ -119,29 +114,29 @@
 	$cnt_group++;
 }
 
-/*get owner user **********************************************************************************************/
-#$sql_user = "SELECT * FROM mb_user ORDER BY mb_user_name";
-$sql_user = "SELECT * FROM mb_user WHERE mb_user_owner=".$logged_user_id." ORDER BY mb_user_name";
-$res_user = db_query($sql_user);
+/*get owner user **********************************************************************************/
+
+$sql_user = "SELECT * FROM mb_user WHERE mb_user_owner = $1 ORDER BY mb_user_name";
+$v = array($logged_user_id);
+$t = array('i');
+$res_user = db_prep_query($sql_user,$v,$t);
 while($row = db_fetch_array($res_user)){
 	$user_id[$cnt_user] = $row["mb_user_id"];
 	$user_name[$cnt_user] = $row["mb_user_name"];
 	$cnt_user++;
 }
 
-/*get owner group from selected_user******************************************************************************/
+/*get owner group from selected_user***************************************************************/
 
 if(count($user_id)>0){
 	$sql_user_mb_group = "SELECT mb_group.mb_group_id, mb_group.mb_group_name, mb_user_mb_group.fkey_mb_user_id FROM mb_user_mb_group ";
 	$sql_user_mb_group .= "INNER JOIN mb_group ON mb_user_mb_group.fkey_mb_group_id = mb_group.mb_group_id ";
-	$sql_user_mb_group .= "WHERE mb_user_mb_group.fkey_mb_user_id='";
-	
-	if(!$selected_user){$sql_user_mb_group .= $user_id[0];}
-	if($selected_user){$sql_user_mb_group .= $selected_user;}
-	
-	#$sql_user_mb_group .= "' AND mb_group.mb_group_owner = '".$logged_user_id."'";
-	$sql_user_mb_group .= "' ORDER BY mb_group.mb_group_name";
-	$res_user_mb_group = db_query($sql_user_mb_group);
+	$sql_user_mb_group .= "WHERE mb_user_mb_group.fkey_mb_user_id = $1 ";
+	$sql_user_mb_group .= "ORDER BY mb_group.mb_group_name";
+	if(!$selected_user){$v = array($user_id[0]);}
+	if($selected_user){$v = array($selected_user);}
+	$t = array('i');
+	$res_user_mb_group = db_prep_query($sql_user_mb_group,$v,$t);
 	while($row = db_fetch_array($res_user_mb_group)){
 		$group_id_user[$cnt_group_user] = $row["mb_group_id"];
 		$group_name_user[$cnt_group_user] =  $row["mb_group_name"];
@@ -149,9 +144,9 @@
 	}
 
 /*INSERT HTML*/
-echo "<form name='form1' action='" . $PHP_SELF . "?".SID."&e_id_css=".$_REQUEST["e_id_css"]."' method='post'>";
+echo "<form name='form1' action='" . $self ."' method='post'>";
 
-/*insert all user in selectbox*************************************************************************************/
+/*insert all user in selectbox*********************************************************************/
 echo "<div class='text1'>USER: </div>";
 echo "<select style='background:#ffffff' class='select1' name='selected_user' onChange='submit()' size='10'>";
 for($i=0; $i<$cnt_user; $i++){
@@ -163,7 +158,7 @@
 }
 echo "</select>";
 
-/*insert all group in selectbox**************************************************************************/
+/*insert all group in selectbox********************************************************************/
 echo "<div class='text2'>GROUP:</div>";
 echo "<select style='background:#ffffff' class='select2' multiple='multiple' name='selected_group[]' size='$fieldHeight' >";
 for($i=0; $i<$cnt_group; $i++){
@@ -171,7 +166,7 @@
 }
 echo "</select>";
 
-/*Button****************************************************************************************************/
+/*Button*******************************************************************************************/
 
 echo "<div class='button1'><input type='button'  value='==>' onClick='validate(\"insert\")'></div>";
 echo "<input type='hidden' name='insert'>";




More information about the Mapbender_commits mailing list