svn commit: r244 - trunk/mapbender/http/php/mod_filteredUser_filteredGui.php

uli at osgeo.org uli at osgeo.org
Thu May 11 09:13:51 EDT 2006


Author: uli
Date: 2006-05-11 13:13:51+0000
New Revision: 244

Modified:
   trunk/mapbender/http/php/mod_filteredUser_filteredGui.php

Log:
db_prep_query included
verification of user permissions

Modified: trunk/mapbender/http/php/mod_filteredUser_filteredGui.php
Url: https://mapbender.osgeo.org/source/browse/mapbender/trunk/mapbender/http/php/mod_filteredUser_filteredGui.php?view=diff&rev=244&p1=trunk/mapbender/http/php/mod_filteredUser_filteredGui.php&p2=trunk/mapbender/http/php/mod_filteredUser_filteredGui.php&r1=243&r2=244
==============================================================================
--- trunk/mapbender/http/php/mod_filteredUser_filteredGui.php	(original)
+++ trunk/mapbender/http/php/mod_filteredUser_filteredGui.php	2006-05-11 13:13:51+0000
@@ -17,13 +17,13 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 
-session_start();
 import_request_variables("PG");
-require_once("../php/mb_validateSession.php");
 require_once("../../conf/mapbender.conf");
-$con = db_connect($DBSERVER,$OWNER,$PW);
+$con = db_connect(DBSERVER,OWNER,PW);
 db_select_db(DB,$con);
-$gui_id = $_SESSION["mb_user_gui"];
+require_once("../php/mb_validatePermission.php");
+$self = $PHP_SELF . "?".SID."&guiID=".$_REQUEST["guiID"]."&elementID=".$_REQUEST["elementID"];
+
 ?>
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
@@ -63,9 +63,6 @@
 </head>
 <body>
 <?php
-require_once("../../conf/mapbender.conf");
-$con = db_connect($DBSERVER,$OWNER,$PW);
-db_select_db(DB,$con);
 
 require_once("../php/mb_getGUIs.php");
 
@@ -85,17 +82,21 @@
 $logged_user_id=$_SESSION["mb_user_id"];
 
 
-/*handle remove, update and insert**************************************************************************************/
+/*handle remove, update and insert*****************************************************************/
 if($insert){
 	if(count($selected_gui)>0){
 		for($i=0; $i<count($selected_gui); $i++){
 			$exists = false;
-			$sql_insert = "SELECT * from gui_mb_user where fkey_mb_user_id = '".$selected_user."' and fkey_gui_id = '".$selected_gui[$i]."'";
-			$res_insert = db_query($sql_insert);
+			$sql_insert = "SELECT * from gui_mb_user where fkey_mb_user_id = $1 and fkey_gui_id = $2";
+			$v = array($selected_user,$selected_gui[$i]);
+			$t = array('i','s');
+			$res_insert = db_prep_query($sql_insert,$v,$t);
 			while(db_fetch_row($res_insert)){$exists = true;}
 			if($exists == false){
-				$sql_insert = "INSERT INTO gui_mb_user(fkey_mb_user_id, fkey_gui_id) VALUES('$selected_user', '".$selected_gui[$i]."');";
-				$res_insert = db_query($sql_insert);
+				$sql_insert = "INSERT INTO gui_mb_user(fkey_mb_user_id, fkey_gui_id) VALUES($1, $2)";
+				$v = array($selected_user,$selected_gui[$i]);
+				$t = array('i','s');
+				$res_insert = db_prep_query($sql_insert,$v,$t);
 			}
 		}
 	}
@@ -103,18 +104,21 @@
 if($remove){
 	if(count($remove_gui)>0){
 		for($i=0; $i<count($remove_gui); $i++){
-			$sql_remove = "DELETE FROM gui_mb_user WHERE fkey_gui_id = '".$remove_gui[$i]."' and fkey_mb_user_id = '$selected_user'";
-			db_query($sql_remove);
+			$sql_remove = "DELETE FROM gui_mb_user WHERE fkey_gui_id = $1 and fkey_mb_user_id = $2";
+			$v = array($remove_gui[$i],$selected_user);
+			$t = array('s','i');
+			db_prep_query($sql_remove,$v,$t);
 		}
 	}
 }
 
 
 
-/*get owner user **********************************************************************************************/
-$sql_user = "SELECT * FROM mb_user WHERE mb_user_owner=".$logged_user_id." ORDER BY mb_user_name";
-
-$res_user = db_query($sql_user);
+/*get owner user **********************************************************************************/
+$sql_user = "SELECT * FROM mb_user WHERE mb_user_owner = $1 ORDER BY mb_user_name";
+$v = array($logged_user_id);
+$t = array('i');
+$res_user = db_prep_query($sql_user,$v,$t);
 while($row = db_fetch_array($res_user)){
 	$user_id[$cnt_user] = $row["mb_user_id"];
 	$user_name[$cnt_user] = $row["mb_user_name"];
@@ -123,75 +127,77 @@
 
 
 
-/*get allocated gui  ********************************************************************************************/
-#$sql_gui = "SELECT * FROM gui ORDER BY gui_name";
+/*get allocated gui  ******************************************************************************/
 
 $arrayGuis=mb_getGUIs($logged_user_id);
-
+$v = array();
+$t = array();
 $sql_gui = "SELECT * FROM gui WHERE gui_id IN (";
 
 for($i=0; $i<count($arrayGuis); $i++){
 	if($i>0){ $sql_gui .= ",";}
-	$sql_gui .= "'".$arrayGuis[$i]."'";
+	$sql_gui .= "$".($i + 1);
+	array_push($v,$arrayGuis[$i]);
+	array_push($t,'s');
 }
 $sql_gui.= ") ORDER BY gui_name";
 
-$res_gui = db_query($sql_gui);
+$res_gui = db_prep_query($sql_gui,$v,$t);
 while($row = db_fetch_array($res_gui)){
 	$gui_id_array[$cnt_gui] = $row["gui_id"];
 	$gui_name[$cnt_gui] = $row["gui_name"];
 	$cnt_gui++;
 }
 
-
-
-/*get allocated gui from logged_user******************************************************************************/
+/*get allocated gui from logged_user***************************************************************/
 
 $sql_logged_user_mb_gui = "SELECT gui.gui_id, gui.gui_name, gui_mb_user.fkey_mb_user_id FROM gui_mb_user ";
 $sql_logged_user_mb_gui .= "INNER JOIN gui ON gui_mb_user.fkey_gui_id = gui.gui_id ";
-$sql_logged_user_mb_gui .= "WHERE gui_mb_user.fkey_mb_user_id='".$logged_user_id."'";
+$sql_logged_user_mb_gui .= "WHERE gui_mb_user.fkey_mb_user_id = $1";
 $sql_logged_user_mb_gui .= " ORDER BY gui.gui_name";
-
-
-$res_logged_user_mb_all_gui = db_query($sql_logged_user_mb_gui);
+$v = array($logged_user_id);
+$t = array('i');
+$res_logged_user_mb_all_gui = db_prep_query($sql_logged_user_mb_gui,$v,$t);
 while($row = db_fetch_array($res_logged_user_mb_all_gui)){
 	$gui_id_logged_user[$cnt_gui_logged_user] = $row["gui_id"];
 	$gui_name_logged_user[$cnt_gui_logged_user] =  $row["gui_name"];
 	$cnt_gui_logged_user++;
 }
 
-/*get allocated gui from selected_user******************************************************************************/
+/*get allocated gui from selected_user*************************************************************/
 $arrayGuis=mb_getGUIs($logged_user_id);
-
+$v = array();
+$t = array();
 if(count($user_id)>0){
 	$sql_user_mb_gui = "SELECT gui.gui_id, gui.gui_name, gui_mb_user.fkey_mb_user_id FROM gui_mb_user ";
 	$sql_user_mb_gui .= "INNER JOIN gui ON gui_mb_user.fkey_gui_id = gui.gui_id ";
-	$sql_user_mb_gui .= "WHERE gui_mb_user.fkey_mb_user_id=";
-	if(!$selected_user){$sql_user_mb_gui .= $user_id[0];}
-	if($selected_user){$sql_user_mb_gui .= $selected_user;}
+	$sql_user_mb_gui .= "WHERE gui_mb_user.fkey_mb_user_id = $1 ";
+	if(!$selected_user){array_push($v,$user_id[0]);}
+	if($selected_user){array_push($v,$selected_user);}
+	array_push($t,'i');
 	$sql_user_mb_gui .= " AND gui.gui_id IN(";
+	$c = 2;
 	for($i=0; $i<count($arrayGuis); $i++){
-	 if($i>0){ $sql_user_mb_gui .= ",";}
-	 $sql_user_mb_gui .= "'".$arrayGuis[$i]."'";
+		if($i>0){ $sql_user_mb_gui .= ",";}
+		$sql_user_mb_gui .= "$".$c;
+	 	array_push($v,$arrayGuis[$i]);
+	 	array_push($t,'s');
+		$c++;
 	}
 	$sql_user_mb_gui .= ") ORDER BY gui.gui_name";
 	
-	$res_user_mb_gui = db_query($sql_user_mb_gui);
+	$res_user_mb_gui = db_prep_query($sql_user_mb_gui,$v,$t);
 	while($row = db_fetch_array($res_user_mb_gui)){
 		$gui_id_user[$cnt_gui_user] = $row["gui_id"];
 		$gui_name_user[$cnt_gui_user] =  $row["gui_name"];
 		$cnt_gui_user++;
 	}
 
-
-
-
 /*INSERT HTML*/
-echo "<form name='form1' action='" . $PHP_SELF . "?".SID."&e_id_css=".$_REQUEST["e_id_css"]."' method='post'>";
-#echo "<table bgcolor='lightgrey' border='1' frame='box'>";
+echo "<form name='form1' action='" . $self ."' method='post'>";
 
 
-/*insert all user in selectbox*************************************************************************************/
+/*insert all user in selectbox*********************************************************************/
 echo "<div class='text1'>USER: </div>";
 echo "<select style='background:#ffffff' class='select1' name='selected_user' onChange='submit()' size='10'>";
 for($i=0; $i<$cnt_user; $i++){
@@ -202,20 +208,20 @@
    echo ">" . $user_name[$i] . "</option>";
 }
 echo "</select>";
-/*insert allocated gui in selectbox**************************************************************************/
+/*insert allocated gui in selectbox****************************************************************/
 echo "<div class='text2'>GUI: </div>";
 echo "<select style='background:#ffffff' class='select2' multiple='multiple' name='selected_gui[]' size='$fieldHeight' >";
 for($i=0; $i<$cnt_gui; $i++){
    echo "<option value='" . $gui_id_array[$i]  . "'>" . $gui_name[$i]  . "</option>";
 }
 echo "</select>";
-/*Button****************************************************************************************************/
+/*Button*******************************************************************************************/
 echo "<div class='button1' ><input type='button'  value='==>' onClick='validate(\"insert\")'></div>";
 echo "<input type='hidden' name='insert'>";
 echo "<div class='button2'><input type='button' value='<==' onClick='validate(\"remove\")'></div>";
 echo "<input type='hidden' name='remove'>";
 
-/*insert user_gui_dependence in selectbox**************************************************/
+/*insert user_gui_dependence in selectbox**********************************************************/
 echo "<div class='text3'>SELECTED GUI:</div>";
 echo "<select style='background:#ffffff' class='select3' multiple='multiple' name='remove_gui[]' size='$fieldHeight' >";
 for($i=0; $i<$cnt_gui_user; $i++){
@@ -236,8 +242,5 @@
 document.forms[0].selected_user.focus();
 // -->
 </script>
-
-
-
 </body>
 </html>
\ No newline at end of file




More information about the Mapbender_commits mailing list