[Mapbender-dev] [Mapbender] #915: text css as element-var

Wed Jun 11 11:18:13 PDT 2014

#915: text css as  element-var
----------------------------+-----------------------------------------------
 Reporter:  marcm           |       Owner:  dev          
     Type:  defect          |      Status:  new          
 Priority:  major           |   Milestone:  2.7.4 release
Component:  administration  |     Version:  2.7.3        
 Keywords:                  |  
----------------------------+-----------------------------------------------
 Since Mapbender 2.7 the "text/css" statements in element-var doesnt work.
 (File/css works fine)

The reason is in a comment block (<!-- ) in index.php before the text css
 is produced.

 see:
 {{{
 <style type="text/css">
         <!--
         <?php
                 $sql = <<<SQL

         SELECT DISTINCT e_id, e_element, var_value, var_name, var_type
 FROM gui_element, gui_element_vars
         WHERE
                 e_id = fkey_e_id
                 AND e_element <> 'iframe'
                 AND gui_element.fkey_gui_id = $1
                 AND gui_element_vars.fkey_gui_id = $1
                 AND var_type = 'text/css'
         ORDER BY var_name

         SQL;

                 $v = array($gui_id);
                 $t = array('s');
                 $res = db_prep_query($sql,$v,$t);
                 $cnt = 0;
                 while($row = db_fetch_array($res)){
                         echo $row["var_value"] . "\n";
                 }
         ?>
         -->
         </style>
 }}}
 With Mapbender 2.6 everything worked fine.
 Maybe the different Doctype declaration...?.
 MB2.6=
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

 MB2.7=
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
 http://www.w3.org/TR/html4/loose.dtd">

 I think deleting the comment statement should solve this.
 (I hope this causes no other Browser incompatibility... :-) )
 What do you think?

-- 
Ticket URL: <http://trac.osgeo.org/mapbender/ticket/915>
Mapbender <http://www.mapbender.org/>
Mapbender