[mapguide-commits] r4470 - sandbox/rfc60/MgDev/Common/MapGuideCommon/Resources

[svn_mapguide at osgeo.org]

Author: waltweltonlair
Date: 2009-12-23 17:51:43 -0500 (Wed, 23 Dec 2009)
New Revision: 4470

Modified:
   sandbox/rfc60/MgDev/Common/MapGuideCommon/Resources/mapguide_en.res
Log:
RFC60 fixes to ServerRenderingService.cpp

 * Fixed a memory leak.  In the case of AGG the RS_ColorVector object is
   allocated but never deleted.  Fixed by allocating the RS_ColorVector
   object on the stack.

 * Fixed logic error.  When getting the image data from the renderer, the code
   which checks for the AGG renderer also now included a check for hasColorMap.
   If the renderer is AGG but hasColorMap returned false then the code would
   incorrectly jump to the else block and use GD renderer.

 * Fixed exception usage (1).  When the renderer returns no data the code now
   throws an exception.  Original an MgNullArgumentException was raised, and
   in my review comments I suggested using MgStylizeLayerFailedException instead.
   Turns out that one doesn't work because it requires a specific layer as a
   what argument.  Looking through the exception types, the right one is
   actually MgNullReferenceException.

 * Fixed exception usage (2).  When creating the exception the message argument
   needs to be an id of a message in the resource file, and not the message itself.
   I added a new id to the resource file with the desired message.


Modified: sandbox/rfc60/MgDev/Common/MapGuideCommon/Resources/mapguide_en.res
===================================================================
--- sandbox/rfc60/MgDev/Common/MapGuideCommon/Resources/mapguide_en.res	2009-12-23 22:51:30 UTC (rev 4469)
+++ sandbox/rfc60/MgDev/Common/MapGuideCommon/Resources/mapguide_en.res	2009-12-23 22:51:43 UTC (rev 4470)
@@ -291,6 +291,7 @@
 MgMissingSchema                                       = No schema specified.
 MgMissingSrs                                          = No coordinate system specified.
 MgNameNotFound                                        = The name was not found.
+MgNoDataFromRenderer                                  = No data from renderer.
 MgPropertyValuesEmpty                                 = The property values cannot be empty. 
 MgReaderIdNotFound                                    = The reader ID was not found.
 MgRepositoryAlreadyOpened                             = The repository is already opened by another process (e.g. If you are running the server interactively as an application from the command line, are you also running the server as a service?).