[mapguide-commits] r7764 - in trunk/MgDev: Server/src/Common/Manager Web/src/ApacheAgent Web/src/CgiAgent Web/src/IsapiAgent Web/src/mapviewerjava Web/src/mapviewernet
svn_mapguide at osgeo.org
svn_mapguide at osgeo.org
Wed Aug 14 04:37:17 PDT 2013
Author: jng
Date: 2013-08-14 04:37:17 -0700 (Wed, 14 Aug 2013)
New Revision: 7764
Modified:
trunk/MgDev/Server/src/Common/Manager/FdoConnectionManager.cpp
trunk/MgDev/Web/src/ApacheAgent/ApacheResponseHandler.cpp
trunk/MgDev/Web/src/CgiAgent/CgiResponseHandler.cpp
trunk/MgDev/Web/src/IsapiAgent/IsapiResponseHandler.cpp
trunk/MgDev/Web/src/mapviewerjava/serveradminhelper.jsp
trunk/MgDev/Web/src/mapviewernet/serveradminhelper.aspx
Log:
#2261: A review of the codebase where calls to MgException::GetDetails() were made found these areas where redundant information was saved/written/kogged. GetDetails() is the *full* message/stack/etc, so anything else saved/written/logged out is redundant. Such bits of code have been removed.
Modified: trunk/MgDev/Server/src/Common/Manager/FdoConnectionManager.cpp
===================================================================
--- trunk/MgDev/Server/src/Common/Manager/FdoConnectionManager.cpp 2013-08-13 14:46:28 UTC (rev 7763)
+++ trunk/MgDev/Server/src/Common/Manager/FdoConnectionManager.cpp 2013-08-14 11:37:17 UTC (rev 7764)
@@ -356,8 +356,6 @@
MgResources::DefaultMessageLocale : serverManager->GetDefaultMessageLocale();
STRING message = ex->GetDetails(locale);
- message += L"\n";
- message += ex->GetStackTrace(locale);
MgStringCollection args;
args.Add(resourceIdentifier->ToString());
args.Add(message);
Modified: trunk/MgDev/Web/src/ApacheAgent/ApacheResponseHandler.cpp
===================================================================
--- trunk/MgDev/Web/src/ApacheAgent/ApacheResponseHandler.cpp 2013-08-13 14:46:28 UTC (rev 7763)
+++ trunk/MgDev/Web/src/ApacheAgent/ApacheResponseHandler.cpp 2013-08-14 11:37:17 UTC (rev 7764)
@@ -179,7 +179,7 @@
{
MG_TRY()
STRING shortError = e->GetExceptionMessage();
- STRING longError = e->GetDetails();
+ STRING stackTrace = e->GetStackTrace();
STRING statusMessage = e->GetClassName();
//TODO: Use a string resource for html error text format
@@ -200,7 +200,7 @@
"<body>\n<h2>%s</h2>\n%s\n</body>\n</html>\n",
MG_WCHAR_TO_CHAR(statusMessage),
MG_WCHAR_TO_CHAR(shortError),
- MG_WCHAR_TO_CHAR(longError));
+ MG_WCHAR_TO_CHAR(stackTrace));
MG_CATCH(L"ApacheResponseHandler.SendError")
Modified: trunk/MgDev/Web/src/CgiAgent/CgiResponseHandler.cpp
===================================================================
--- trunk/MgDev/Web/src/CgiAgent/CgiResponseHandler.cpp 2013-08-13 14:46:28 UTC (rev 7763)
+++ trunk/MgDev/Web/src/CgiAgent/CgiResponseHandler.cpp 2013-08-14 11:37:17 UTC (rev 7764)
@@ -178,8 +178,9 @@
{
MG_TRY()
STRING shortError = e->GetExceptionMessage();
+ STRING stackTrace = e->GetStackTrace();
+ STRING statusMessage = e->GetClassName();
STRING longError = e->GetDetails();
- STRING statusMessage = e->GetClassName();
//TODO: Use a string resource for html error text format
printf(MapAgentStrings::StatusHeader, 559, MG_WCHAR_TO_CHAR(statusMessage));
@@ -192,7 +193,7 @@
"<body>\n<h2>%s</h2>\n%s\n</body>\n</html>\n",
MG_WCHAR_TO_CHAR(statusMessage),
MG_WCHAR_TO_CHAR(shortError),
- MG_WCHAR_TO_CHAR(longError));
+ MG_WCHAR_TO_CHAR(stackTrace));
DumpMessage(MG_WCHAR_TO_CHAR(longError));
Modified: trunk/MgDev/Web/src/IsapiAgent/IsapiResponseHandler.cpp
===================================================================
--- trunk/MgDev/Web/src/IsapiAgent/IsapiResponseHandler.cpp 2013-08-13 14:46:28 UTC (rev 7763)
+++ trunk/MgDev/Web/src/IsapiAgent/IsapiResponseHandler.cpp 2013-08-14 11:37:17 UTC (rev 7764)
@@ -192,7 +192,7 @@
{
MG_TRY()
STRING shortError = e->GetExceptionMessage();
- STRING longError = e->GetDetails();
+ STRING stackTrace = e->GetStackTrace();
STRING statusMessage = e->GetClassName();
DWORD status = 559;
@@ -217,7 +217,7 @@
"<body>\n<h2>%s</h2>\n%s\n</body>\n</html>\n",
MG_WCHAR_TO_CHAR(statusMessage),
MG_WCHAR_TO_CHAR(shortError),
- MG_WCHAR_TO_CHAR(longError));
+ MG_WCHAR_TO_CHAR(stackTrace));
MG_CATCH(L"IsapiResponseHandler.SendError")
Modified: trunk/MgDev/Web/src/mapviewerjava/serveradminhelper.jsp
===================================================================
--- trunk/MgDev/Web/src/mapviewerjava/serveradminhelper.jsp 2013-08-13 14:46:28 UTC (rev 7763)
+++ trunk/MgDev/Web/src/mapviewerjava/serveradminhelper.jsp 2013-08-14 11:37:17 UTC (rev 7764)
@@ -142,7 +142,6 @@
}
catch (MgException mge)
{
- outStream.write(mge.GetExceptionMessage());
outStream.write(mge.GetDetails());
}
Modified: trunk/MgDev/Web/src/mapviewernet/serveradminhelper.aspx
===================================================================
--- trunk/MgDev/Web/src/mapviewernet/serveradminhelper.aspx 2013-08-13 14:46:28 UTC (rev 7763)
+++ trunk/MgDev/Web/src/mapviewernet/serveradminhelper.aspx 2013-08-14 11:37:17 UTC (rev 7764)
@@ -130,7 +130,6 @@
}
catch (MgException mge)
{
- Response.Write(mge.GetExceptionMessage());
Response.Write(mge.GetDetails());
}
}
More information about the mapguide-commits
mailing list