[mapguide-internals] For Review : Mapguide RFC 31-SymbolDefinition Support for Edit Controls and RichTextSupport (Markup)

[Vishal Bangia]

>From my point of view the DataType element enumerations serve an
explicit purpose.
That purpose being to precisely codify what data values the Symbol
Parameter expects.

To better explain that . Let's take a step back and look at the
Symbolization schema :
1) ParameterDefinition element and its contained Parameters are a way of
presenting an interface to the Symbol.
2) The DataType element allows the Symbol consumer to look at the
interface and know what type of information is required. While one might
argue and say it should be a float, string etc. an equally compelling
argument is that DataType instead of hewing to such a generic approach
should be truly rich in its description by accurately specifying what
Data values it expect.(in that manner LineColor is different from
FillColor)
3) Additionally, its gives any intermediate software component the
ability to present the choices to the end user in a far more coherent
manner.


Traian, now to explicitly address the concerns (as per the thread
below).
You raise an interesting point when you say that the use of the
parameter inside the Angle element means that that the interface (aka
Parameter element) should not specify a DataType of type Angle as it is
redundant.

If you look at it from an DataModel POV, the end user should not concern
themselves beyond the interface i.e. They should not look beyond what is
defined within the ParameterDefinition element for a given Symbol. True,
the example is fairly simple but could easily have used LBL_ROTATION in
a complex expression within the Angle element. Should the user have to
parse the expression to figure out if LBL_ROTATION is used in the Angle
element ? I think not. The same applies to all the other elements within
the SymbolDefinition.  

   
Cheers,
Vishal 




-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org
[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Traian
Stanev
Sent: Tuesday, September 18, 2007 9:44 AM
To: mapguide-internals at lists.osgeo.org
Subject: RE: [mapguide-internals] For Review : Mapguide RFC
31-SymbolDefinition Support for Edit Controls and RichTextSupport
(Markup) 


I am concerned about the new additions to the DataType element. Most of
them are redunadant. Even in the example given in the RFC, the DataType
is set to Angle and specifies that the LBL_ROTATION parameter represents
an Angle. The LBL_ROTATION itself is already referenced inside an
<Angle> element, so there really is no point to specifying a data type
for it. 

Apart from the redundancy, my concern is that client apps will be coded
to rely on those data type hints exclusively instead of inferring the
data types from the actual contents of the symbol and thus will be
unable to consume symbols created by third parties without undue burden
on the third party to add all those "optional" DataType elements.

Also, the element name DataType is not even meaningful anymore if it can
be set to things like "FillColor" or "LineColor" since arguably these
are both the same data type (color).


Traian



-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org
[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Vishal
Bangia
Sent: Tuesday, September 18, 2007 12:25 PM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] For Review : Mapguide RFC 31
-SymbolDefinition Support for Edit Controls and Rich TextSupport
(Markup) 

 

Hi All,

 

Mapguide RFC 31  (SymbolDefinition Support for Edit Controls and Rich
Text Support (Markup))  is available for review.

http://trac.osgeo.org/mapguide/wiki/MapGuideRfc31

 

Your participation and feedback will be appreciated. 

 

Thank you,

Vishal

_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals


_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals