[mapguide-internals] MapGuide RFC 49 - Enhance ServerErrorReporting

[Trevor Wekel]

Well...

I was chatting with Bruce about this one today but it could have some negative impacts.  I could add a "TreatWarningAsError" parameter to serverconfig.ini.  This would upgrade all warnings to full blown exceptions with complete stack trace information.

It could be difficult to implement depending on catch logic but I will investigate it.  And it would completely kill your map unless all the stylization, labels, etc, were 100% perfect.

Trevor


-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jason Birch
Sent: Monday, June 16, 2008 8:36 PM
To: mapguide-internals at lists.osgeo.org
Subject: Re: [mapguide-internals] MapGuide RFC 49 - Enhance ServerErrorReporting

Thanks for follow-up. Gotta love a layman asking for the impossible, eh?  :)

I'm personally not convinced that continuing on exception is a good strategy. It reduces the likelihood that a problem will be noticed and reported, and increases the likelihood of publishing information that is incorrect when displayed out of context.


----- Original Message -----
From: mapguide-internals-bounces at lists.osgeo.org <mapguide-internals-bounces at lists.osgeo.org>
To: MapGuide Internals Mail List <mapguide-internals at lists.osgeo.org>
Sent: Mon Jun 16 19:10:01 2008
Subject: RE: [mapguide-internals] MapGuide RFC 49 - Enhance ServerErrorReporting

Hi Jason,

FDO uses a different set of classes for exceptions and changing core FDO code is a little out of scope for a MapGuide RFC.  The MapGuide Server is capable of catching FDO exceptions but we will not get any stack or call parameter information from FDO.

There's a couple of places where we can trap FDO exceptions:

1. Direct API calls to FeatureService from scripts, etc.

These calls should throw the FDO exception and return the FDO exception message, the MapGuide stack trace, and the MapGuide call parameters.

2. Calls to FDO via the Stylizer (i.e. MappingService)

The stylizer catches FDO exceptions.  I have added a hook allow the MapGuide Server to log these exceptions as warnings.  Since we do not throw them, it is impossible to generate a stack trace and still maintain the same functionality.  If we throw, we will fail the stylization on all the layers and not just the bad one(s).

However, the trace log will tell you what was executing at the time.  It is not as clean as a stack trace but it should be functional.  The trace log in the RFC is an example of this.  The MgStylizationUtil.ExceptionTrap is written into the trace log file and all of the entries above it are on the same thread (4972) so they apply to that exception.  The warning is also written to the error log but it does not give the stack information.

As for more FDO information, the MgServerFeatureService.SelectFeatures does contain a fair bit of information:

Resource=Library://Samples/Sheboygan/Data/VotingDistricts.FeatureSource
ClassName=SDF_2_Schema:VotingDistricts
Options={{Operator=1}{GeomProp=Data}{GeomOp=10}{Geometry=POLYGON ((-87.783866628374042 43.691398128787803, -87.676641873488435 43.691398128787803, -87.676641873488435 43.797520000480297, -87.783866628374042 43.797520000480297, -87.783866628374042 43.691398128787803))}}

Thanks,
Trevor

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jason Birch
Sent: Monday, June 16, 2008 7:28 PM
To: mapguide-internals at lists.osgeo.org
Subject: Re: [mapguide-internals] MapGuide RFC 49 - Enhance Server ErrorReporting

Yes please :)

Absolutely in favour of this.  It would be great to be able to know what queries and/or data are causing problems. Right now it is hard to file a small reproducible bug report.

Does/will this turn on tracing inside FDO also?  Is that an option?  This would make it easier for provider developers to see what mapguide is doing when things go awry :)

Jason


----- Original Message -----
From: mapguide-internals-bounces at lists.osgeo.org <mapguide-internals-bounces at lists.osgeo.org>
To: MapGuide Internals Mail List <mapguide-internals at lists.osgeo.org>
Sent: Mon Jun 16 17:57:45 2008
Subject: [mapguide-internals] MapGuide RFC 49 - Enhance Server ErrorReporting

I would like to submit MapGuide RFC 49 - Enhance Server Error Reporting for review and comment.

http://trac.osgeo.org/mapguide/wiki/MapGuideRfc49

Thanks,
Trevor
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals