[mapguide-internals] [Code Review]https://trac.osgeo.org/mapguide/ticket/1166

[Arthur Liu]

Hi all,

Would you please review the patch https://trac.osgeo.org/mapguide/attachment/ticket/1166/Patch1166.patch for https://trac.osgeo.org/mapguide/ticket/1166?

Comments:
The method setActiveTab() of Jx.TabSet will be invoked while user selects Show Legend Panel in View widget. However, it seems that this method was not designed for selection changing in View widget but button clicking on the TabBox, which will not active the selected tab. Button click in the TabBox will invoke setActive(true) method in tab items which will call setActiveTab(), so we can simply update method tabBox.tabSet.setActiveTab(tab) to tab.setActive(true) in MapGuide templates

Thanks,
Arthur