[mapguide-internals] [Code Review Request]: Please Review the patch
for Ticket 1193
Buddy Hu
Buddy.Hu at autodesk.com
Wed Dec 9 21:21:04 EST 2009
Hi list,
I've attached a patch for ticket #1193, please review it: https://trac.osgeo.org/mapguide/ticket/1193
Some comments:
[Problem]
Select-within causes a 500 Internal error in the browser, when select multi features(including polygon and other types).
There are some logic errors in the selectwithin.php (jsp and aspx have the same problem). It uses the type of the first feature as the type for all the other features. If the first feature is a polygon, it adds all features into a MgPolygonColloection, then 500 Internal Server error happens.
The fusion has same problem.
[Solution]
Get the type of all features, if it's not polygon, we will break. Because, the Select-within only works for polygon.
Regards,
-Buddy Hu
More information about the mapguide-internals
mailing list