[mapguide-internals] rfc60 ready for review

[Tom Fukushima]

Hi UV,

Since this is a large submission, please answer the following questions and requests for info, so we can figure out the logistics of getting the review done.

1) When do you need the review done by, do you have any pending hard deadlines?  MGOS 2.2 doesn't have a cut off that I know of yet so if all you want is for this to go into 2.2 we do have some time.

2) I noticed that you did a sync of your sandbox with trunk.  I think that the reviewers will just diff the sandbox with trunk to see what the changes are.  Which revision of trunk did you sync your sandbox with?

3) You say below that there were other changes that are not related to RFC 60.  There will be different reviewers for the RFC 60 part and the non-RFC 60 parts.  Please specify the list of files that were changed but were not related to RFC 60.

Thanks
Tom



-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of UV
Sent: December-09-09 5:57 PM
To: MapGuide Internals Mail List
Subject: [mapguide-internals] rfc60 ready for review

In the sandbox on
    http://svn.osgeo.org/mapguide/sandbox/rfc60/MgDev
you can find a feature branch which is ready to be merged with trunk.
This codetree includes code to deal with new stylization and lookup of 
symboldefinitions in addition to the color lookup in the previous 
stylization.

*in MappingUtil (ExtractColors, FindColorInSymDefHelper)
    strings are collected from the xml definition of the scaleRanges 
which are describing stylization colors.
*in ServerRenderingService (RenderMapInternal:777, ParseColorStrings)
    after the Stylization the found strings are converted into colors 
and passed on to the AGGRenderer
*in AGGImageIo (ImageCopyForcePaletteGD)
    a provided colorpalette is used to optimize the colorquantization 
algorithm for the tile

this code is only executed for PNG8 and GIF tiles.

I further added comments for some existing methods and did some method 
extraction while trying to understand the code.

The interesting question is now if the colors found in the new 
stylization can overlap tile boundaries in a visible way and therefore 
need to be included into the color quantization optimization?

In our map the long edges of the ocean areas with slightly different 
colors where the only ones we could spot,
whereas a slight color change of a line crossing a tile boundary is 
quite hard to spot.


Other than that, this feature is a MUST for everyone using colormapped 
tiles as otherwise such map simply looks ugly .
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals