[mapguide-internals] Found at least one memory leaks in Mapguide API

[Walt Welton-Lair]

Yes, we missed this one.  I'm submitting it now.  Thanks for tracking this down!

So here are the four fixes:

https://trac.osgeo.org/mapguide/changeset/3982#file6 (the 2 fixes in WebLayout.cpp)
https://trac.osgeo.org/mapguide/changeset/3987
https://trac.osgeo.org/mapguide/changeset/3996

Does that match what you have?

Walt


-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Bruno Scott
Sent: Wednesday, July 08, 2009 8:20 AM
To: mapguide-internals at lists.osgeo.org
Subject: RE: [mapguide-internals] Found at least one memory leaks in Mapguide API


Yes!
I found it
I has looking at the wrong place.
Same king of bug as the previous ones

int WebLayout.cpp in the ParseFlyoutWidget function there was
            else if(strName == L"SubItem") //NOXLATE
            {
                widget->AddSubItem(ParseWidget(elt));
             }
It need to be replaced by
            else if(strName == L"SubItem") //NOXLATE
            {
                Ptr<MgWebWidget> subWidget = ParseWidget(elt);
                widget->AddSubItem(subWidget);
            }

With all 4 fixes, w3w memory is stable, no more memory leaks on the
MgWebLayout

Bruno


-- 
View this message in context: http://n2.nabble.com/Found-at-least-one-memory-leaks-in-Mapguide-API-tp3212879p3225104.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals