[mapguide-internals] RE: Please review patch for ticket #1057

Tom Fukushima tom.fukushima at autodesk.com
Thu Jul 30 15:18:54 EDT 2009


Hi Trevor,

Please also put your comments in the ticket; I think that helps to make sure things are in a central location.  This may be important when we need to evaluate who to change from "contributor" to "developer".
 
Tom

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Trevor Wekel
Sent: Thursday, July 30, 2009 1:02 PM
To: MapGuide Internals Mail List
Subject: [mapguide-internals] RE: Please review patch for ticket #1057

Hi Christine,

I would simply remove the CheckSpacesAtBeginEnd() call from the code instead of commenting it out.

Did you also validate all calls to CheckReservedCharacters() to ensure that removing the space check would have no side effects?

Thanks,
Trevor

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Christine Bao
Sent: July 30, 2009 2:28 AM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] Please review patch for ticket #1057

Hi all,

     Please review patch https://trac.osgeo.org/mapguide/attachment/ticket/1057/RemoveSpaceCheck.patch. Thank you.

Thanks & regards,
Christine
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals


_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals


More information about the mapguide-internals mailing list