[mapguide-internals] PATCH: Ticket #809

[Chris Claydon]

This looks good to me now.

Chris.

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Wednesday, March 25, 2009 5:14 AM
To: mapguide-internals at lists.osgeo.org
Subject: RE: [mapguide-internals] PATCH: Ticket #809


Hi Chris,

Here's a 2nd version of the patch that handles urls with and without the query string component.

http://trac.osgeo.org/mapguide/attachment/ticket/809/809v2.patch

- Jackie


Overall this looks good, but I have one concern...

Does this code work if your initial URL doesn't contain a '?' character?

I would have thought that (at least in the aspx version) url.IndexOf("?") would return -1 and that this would cause an exception when used in url.Substring(0, url.IndexOf("?").

Chris. 

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Tuesday, March 24, 2009 7:50 AM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] PATCH: Ticket #809


I'd like a review of this patch before I commit the thing

http://trac.osgeo.org/mapguide/attachment/ticket/809/809.patch

This patch allows you to specify an initial URL in the task pane that has parameters. Previously this was not possible as any extra parameters would get discarded.

- Jackie
-- 
View this message in context: http://n2.nabble.com/PATCH%3A-Ticket--809-tp2526600p2526600.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.

_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals



-- 
View this message in context: http://n2.nabble.com/PATCH%3A-Ticket--809-tp2526600p2531803.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.

_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals