[mapguide-internals] RFC60 for vote please
walt.welton-lair at autodesk.com
Thu May 7 23:20:32 EDT 2009
I think the patch is ok, and we should probably move forward with it.
However, I still have a gripe with RFC60 in that it leaves out the new enhanced stylization work (Composite Symbolizations). The RFC says:
In this phase only the colors from the VectorLayerDefinitions and in there the Area, Line, and Point Symbolizations
are parsed as cleartext. Any further evaluation requires resource lookups which are a higher order of complexity and
should not be permanently enabled.
Like the resource lookup this can be added at a later point in time...
What exactly do you mean by "should not be permanently enabled"? In what "phase" will the remaining work be done? Who's going to do this?
Bottom line, as soon as you submit your patch you've created a new defect - PNG8 tiles created for layers that use the enhanced stylization will be incorrect.
Another reason why it's important to not ignore composite symbolizations is that it influences your SW design. As you know composite symbolizations support both inlined and referenced symbols (via resource IDs). Your current design (adding a GetUsedColorList method to VectorScaleRange) works for inlined symbols but not for referenced symbols. The MdfModel does not know about resources / resource service (nor should it), so it won't be possible to look up the referenced symbols and obtain their colors with your current design. The GetUsedColorList implementation needs to be moved somewhere else to correctly support composite symbolizations. (I originally explained all this in an email back on March 24th.)
Anyway, let's not keep this from moving forward with RFC60. But I would like some answers to my questions.
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of UV
Sent: Thursday, May 07, 2009 12:05 AM
To: MapGuide Internals Mail List
Subject: [mapguide-internals] RFC60 for vote please
Please have a look at the patch submitted for RFC60.
This is straightforward code so lets please commit it finally.
* Collection of color strings in VectorScale.
* Pruning the list in the renderer service. (this is were those strings
can be parsed differently)
* Using the list in AGGImageIo.
The rest is comments and boilerplate code passing on parameters.
Any additional functionality can be easily added later.
I spent months now evaluating this patch as I had to be sure that the
problems were not from my code.
So I am sure now that any problems I found are in any release build as
of 2.1 where incomplete tiles can be generated.
This, as we know now, has been called a feature and is caused by the
exception handling in the stylization code
which can be caused by resource limitations of the server.
But this is not part of RFC60.
So as there were no comments for quite some weeks this should be ready
Its difficult to work on different patches without a repository.
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
More information about the mapguide-internals