[mapguide-internals] RE: MapGuide RFC 84 is updated.

[Trevor Wekel]

Hi Leaf,  updating MgFeatureQueryOptions instead of the SelectFeatures, SelectAggregate signatures makes sense to me.  The internal member variable should default to 0 to retain the current behaviour of the existing API methods.

Since ExecuteSqlQuery does not use MgFeatureQueryOptions, a new signature with the fetchSize parameter will have to be added.  Both signatures for ExecuteSqlQuery will have to remain in the API for backward compatibility.

Thanks,
Trevor

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Leaf Li
Sent: September 16, 2009 1:59 AM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] MapGuide RFC 84 is updated.

All,

Previously, we added one more parameter fetchSize for the following two methods in RFC 84 so that they can support fetch size. However, it is more reasonable to add fetchSize as a new member of class MgFeatureQueryOptions because it is one query options. So I update RFC84 to reflect this change. Can you review it?

    virtual MgFeatureReader* SelectFeatures(   
                                  MgResourceIdentifier* resource,
                                  CREFSTRING className,
                                  MgFeatureQueryOptions* options,
                                  CREFSTRING coordinateSystem,
                                  INT32 fetchSize ) = 0; 
 
    virtual MgDataReader* SelectAggregate( 
                                 MgResourceIdentifier* resource,
                                 CREFSTRING className,
                                 MgFeatureAggregateOptions* options,
                                 INT32 fetchSize) = 0;
 
Notes: MgFeatureAggregateOptions inherits from MgFeatureQueryOptions.

http://trac.osgeo.org/mapguide/wiki/MapGuideRfc84

Thanks,
Leaf Li
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals