[mapguide-internals] RE: mapguide-internals Digest, Vol 33, Issue 15

[Leaf Li]

Hi Trevor,

Yes. Fetch size is 0 by default. I add it in RFC.
As for ExecuteSqlQuery, a new signature with fetchSize is already added in RFC. However, we just need add one new signature instead of two because method 1 is an extension to method 2. And method 3 is an extension is to method 3. Method 3 includes all functionality of method 1 and 2.

1. virtual MgSqlDataReader* ExecuteSqlQuery( 
                                 MgResourceIdentifier* resource,
                                 CREFSTRING sqlStatement);

2. virtual MgSqlDataReader* ExecuteSqlQuery( 
                                 MgResourceIdentifier* resource,
                                 CREFSTRING sqlStatement,
                                 MgParameterCollection* params,
                                 MgTransaction* transaction);

3. virtual MgSqlDataReader* ExecuteSqlQuery( 
                                 MgResourceIdentifier* resource,
                                 CREFSTRING sqlStatement,
                                 MgParameterCollection* params,
                                 MgTransaction* transaction,
                                 INT32 fetchSize);

Thanks,
Leaf Li


Message: 3
Date: Wed, 16 Sep 2009 07:02:55 -0700
From: Trevor Wekel <trevor_wekel at otxsystems.com>
Subject: [mapguide-internals] RE: MapGuide RFC 84 is updated.
To: MapGuide Internals Mail List <mapguide-internals at lists.osgeo.org>
Message-ID:
	<7661E3F3A90DBC47869E52672C2E4159F339A0CFD5 at VA3DIAXVS121.RED001.local>
Content-Type: text/plain; charset="iso-8859-1"

Hi Leaf,  updating MgFeatureQueryOptions instead of the SelectFeatures, SelectAggregate signatures makes sense to me.  The internal member variable should default to 0 to retain the current behaviour of the existing API methods.

Since ExecuteSqlQuery does not use MgFeatureQueryOptions, a new signature with the fetchSize parameter will have to be added.  Both signatures for ExecuteSqlQuery will have to remain in the API for backward compatibility.

Thanks,
Trevor