[mapguide-internals] RE: Image size limitation in RenderingService

[Arthur Liu]

Hello Walt,

I updated the patch according to your comments. Thanks for your review.

Regards,
Arthur

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Walt Welton-Lair
Sent: Thursday, September 16, 2010 10:48 PM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] RE: Image size limitation in RenderingService

Hi Arthur,

I looked at the patch, and it looks fine.  The names for the new settings also sound reasonable to me.  I only have minor / nitpicking comments:

* In ServerRenderingService.cpp, move the newly added calls to pConf->GetIntValue to before the "there should be only one instance of this class" comment.  Otherwise it looks like the comment applies to your new calls as well and it doesn't make sense.

* Throughout your patch you declare height before width, e.g.:

# MaxRasterImageHeight             The max height of raster image in pixels
#                                       0 < Value <= 2147483647
# MaxRasterImageWidth              The max width of raster image in pixels
#                                       0 < Value <= 2147483647

I think most people like to see it the other way around - width then height - just like for point coordinates we prefer X then Y.  So switch the order throughout your patch to width then height.

Thanks,
Walt


-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Arthur Liu
Sent: Thursday, September 16, 2010 6:07 AM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] RE: Image size limitation in RenderingService

Thanks for your suggestions.

I created a ticket at http://trac.osgeo.org/mapguide/ticket/1438.

@ Bruce, would you please review the patch at http://trac.osgeo.org/mapguide/attachment/ticket/1438/patch.patch.
I am not sure if "Raster Image" is a proper name, and is it necessary for us to update the default max height and width?

Thanks,
Arthur

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Bruce Dechant
Sent: Thursday, September 16, 2010 3:07 AM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] RE: Image size limitation in RenderingService

I would recommend making it configurable in the serverconfig.ini just in case the administrator wants to control the maximum image size a client can request.

Arthur - could you please create a trac ticket for this issue?

Bruce

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Zac Spitzer
Sent: Wednesday, September 15, 2010 8:51 AM
To: MapGuide Internals Mail List
Subject: Re: [mapguide-internals] RE: Image size limitation in RenderingService

I'd suggest either remove it or make it be configurable via serverconfig.ini

On Thu, Sep 16, 2010 at 12:16 AM, Arthur Liu <arthur.liu at autodesk.com> wrote:
> Thanks for your quick reply Walt.
>
> So, is it a good idea that we remove the check or should we extend the image size limitation?
>
> Regards,
> Arthur
>
> -----Original Message-----
> From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Walt Welton-Lair
> Sent: Wednesday, September 15, 2010 9:43 PM
> To: MapGuide Internals Mail List
> Subject: [mapguide-internals] RE: Image size limitation in RenderingService
>
> The change to RasterAdapter was made 5 years ago.  At the time MapGuide Open Source was under development and only supported a DWF Viewer based client, and the image size limit made sense.  Now that we have image based clients, and also hardware display resolutions have increased over the years, the image size check should probably be changed.
>
> Walt
>
> -----Original Message-----
> From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Arthur Liu
> Sent: Wednesday, September 15, 2010 8:34 AM
> To: MapGuide Internals Mail List
> Subject: [mapguide-internals] Image size limitation in RenderingService
>
> Hi all,
>
> I met a problem when trying to get a map image with size 2048x2048. The image quality drops significantly compare to 2048x2047.
> That happens only in Raster provider and WMS provider,  vector data sources doesn't have this kind of problem.
>
> I found following code in rendering service
>
> RasterAdapter::Stylize()
> {
>   ...
>    while (imgW >= 2048 || imgH >= 2048)
>    {
>        imgW >>= 1;
>        imgH >>= 1;
>    }
>    ...
> }
> The map image can be gennerated sucessfully if I comment out the code.
>
> Does there anyone know why there's a limitation of the map image? Is there any solution or workaround to get a large size map image?
>
> Regards,
> Arthur
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
>



-- 
Zac Spitzer
Solution Architect / Director
Ennoble Consultancy Australia
http://www.ennoble.com.au
http://zacster.blogspot.com
+61 405 847 168
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals