[mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1606/Fix%231606.patch

[Christine Bao]

Hi Zac,

     The stack overflow is not caused by the long string but the hierarchy of objects in the FDO filter getting too large, so simply change OR to IN is not the point.

     The reason why 10M is because Linux has the default stack reserve size as 10M, and based on testing 10M can handle up to 50000 features being selected at one time. This is empirical but practical. 

     Thank you for your comments.

Regards,
Christine

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Zac Spitzer
Sent: Monday, February 21, 2011 2:07 PM
To: MapGuide Internals Mail List
Cc: Christine Bao
Subject: Re: [mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1606/Fix%231606.patch

Hi Christine,

It's probably beyond the scope of this issue, but if the filter clauses is pretty ugly, if the selection filter was changed from OR OR OR to a IN () clause, the example goes for 360 characters to 132, would that improve this, or is it unrelated?

tho FDO doesn't support in clauses yet? might be a nice one for FDO 3.7

Back to the patch, what's the rationale for increasing this value 10 fold?

z


On Mon, Feb 21, 2011 at 4:49 PM, Christine Bao <Christine.Bao at autodesk.com> wrote:
> Hi all,
>
>     Please review http://trac.osgeo.org/mapguide/attachment/ticket/1606/Fix%231606.patch for fixing ticket http://trac.osgeo.org/mapguide/ticket/1606.
>
> Thanks & regards,
> Christine
>
>
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
>



--
Zac Spitzer
Solution Architect / Director
Ennoble Consultancy Australia
http://www.ennoble.com.au
http://zacster.blogspot.com
+61 405 847 168
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals