[mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patch

Thu Sep 1 18:45:04 EDT 2011

Hi Christine,

Looks good.  You could probably use ParseCollection to separate the provider from the timeout setting as well.

Regards,
Trevor

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Christine Bao
Sent: September 1, 2011 12:19 AM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patch

Thanks Trevor for the comments. New attachment  http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout2.patch is done. Please review.

Thanks & regards,
Christine

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Trevor Wekel
Sent: Monday, August 29, 2011 11:25 PM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patch

This would also be appropriate for WFS and should follow "provider specific" semantics like the DataConnectionPoolSizeCustom directive in serverconfig.ini.  We can add a note to the documentation that this is only supported for WMS and WFS.  Personally, I believe  "FDOConnectionTimeoutCustom=OSGeo.WMS:60" is a more self documenting than "FDOConnectionTimeout=60".  The latter also implies that it is applicable to all providers.

Overall, the patch is good.  Adding a few lines to parse "provider specific" timeout values shouldn't be too much overhead.

Regards,
Trevor

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Christine Bao
Sent: August 25, 2011 3:26 AM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patch

Hi Zac,

    Thank you for your comments. 

    Making the connection per provider or even per feature source is more flexible, however it also makes things more complicated. The ConnectionTimeout setting is for handling timeout, and it's useful for the outside server such as WMS, however it's not so useful for internal server such as SQLServer, because the internal server will quickly return error respond. I think because of this situation, FDO providers don't pay much attention to this property, and none of them implement them so far. If MapGuide server has complicated settings for each provider, but FDO part does not support it, it does not make sense. Another thing may be the connection pool, which holds shared connections. If the connection is per feature source, the reusable connection should check setting to use timeout value, and restore to default one when not this feature source. 

    It's the first customer bring up this kind of problem, maybe there will be similar problem for WFS also. But it will rarely happen on file based provider (SDF, SHP etc) or internal server based provider (SQL Server, Oracle etc). Considering FDO situation, I think we don't make things complicated so far. How do you think about it?

    Thank you for your suggestions again!

Thanks & regards,
Christine

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Zac Spitzer
Sent: Thursday, August 25, 2011 4:55 PM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] Please review http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patch

Been thinking about this, a wms response is rather different to a DB connection timeout

The example of a flakey wms server is rather broad. A DB connection hanging on connect is different to a map request hanging

I know no other providers support this yet, but I think that this should be per provider like pooling is.

Also, for the FDO wms provider, I think this should be a per feature source configuration.

Also, my comment was just a quick comment rather than a full review, it's probably better to wait for other people to have a chance to review rather than committing straight away. It just happens we are in similar timezones
:)

Regards

Z
On Aug 25, 2011 5:51 PM, "Christine Bao" <Christine.Bao at autodesk.com> wrote:
> It depends on the FDO provider supports ConnectionTimeout. Currently 
> none
FDO provider supports it, and after this fixing only WMS provider supports it. So the change only applies to WMS provider.
>
> -----Original Message-----
> From: mapguide-internals-bounces at lists.osgeo.org [mailto:
mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Zac Spitzer
> Sent: Thursday, August 25, 2011 3:34 PM
> To: MapGuide Internals Mail List
> Subject: Re: [mapguide-internals] Please review
http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patch
>
> so this is for all FDO connections and not just for WMS?
>
> On Thu, Aug 25, 2011 at 5:28 PM, Christine Bao 
> <Christine.Bao at autodesk.com>
wrote:
>> Hi all,
>>
>>     Please review
http://trac.osgeo.org/mapguide/attachment/ticket/1793/MG_WMSTimeout.patchfor
fixing ticket
http://trac.osgeo.org/mapguide/ticket/1793.
>>
>>     The WIKI http://trac.osgeo.org/mapguide/wiki/ServerconfigWebConfigIniwill be updated to serverconfig.ini change.
>>
>> Thanks & regards,
>> Christine
>>
>> _______________________________________________
>> mapguide-internals mailing list> mapguide-internals at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
>>
>
>
>
> --
> Zac Spitzer
> Solution Architect / Director
> Ennoble Consultancy Australia
> http://www.ennoble.com.au
> http://zacster.blogspot.com
> +61 405 847 168
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals