[mapguide-internals] Patch for ticket 2189: MgLayerCollection::Remove always returns true

[Walt Welton-Lair]

The fix looks good to me.  Could you also please make the same correction to MgLayerGroupCollection:Remove()?

Thanks,
Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Monday, November 26, 2012 10:43 AM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] Patch for ticket 2189: MgLayerCollection::Remove always returns true

Hi All,

Attached is a patch to fix the incorrect behaviour of
MgLayerCollection::Remove() which currently returns true even if you pass in
a layer that doesn't belong in the collection. Even worse, the method will
then detach that layer's parent and track its change.

http://trac.osgeo.org/mapguide/ticket/2189

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-2189-MgLayerCollection-Remove-always-returns-true-tp5018812.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals