[mapguide-internals] Blocking issue in Mapguide 2.4

[Jackie Ng]

OK, I finally had time to rewrite the test case in PHP and the problem has
been exposed wide open.

The problem is we're re-wrapping a partial failure error message in a new
exception, which is re-thrown (to force the "Failure" status in Access.log). 

Doing this however violates the API contract of
MgFeatureService::UpdateFeatures() *as seen from the web tier's point of
view* (if useTransaction = false, no exception should be thrown, instead the
exception is serialized into a MgStringProperty).

Please find the revised patch (2218.patch):
http://trac.osgeo.org/mapguide/ticket/2218

The patch will not re-wrap the partial failure message into a new exception.
Instead that failure message is logged immediately and the original result
(the MgPropertyCollection) is written out to EndExecution().

Please review. I'm certain this will fix UpdateFeatures() once and for all,
as SQLite represents a perfect portable data store to exercise this API in
transactional and non-transactional modes.

Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Blocking-issue-in-Mapguide-2-4-tp5034831p5044023.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.