[mapguide-internals] RFC 133: Additional Stylization Functions

Walt Welton-Lair walt.welton-lair at autodesk.com
Tue Apr 23 07:26:13 PDT 2013


Looks good.  I skimmed through the code as well, and just have a few minor comments:

* for the new source files update the years in the headers to just 2013
* ExpressionFunctionHtmlColor.cpp, line 76 - "three arguments", not "four arguments"?
* could be some tabs in sandbox/jng/extra_stylization_funcs/Server/src/PostBuild/PostBuild.mak

Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Tuesday, April 23, 2013 9:24 AM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] RFC 133: Additional Stylization Functions

Hi All, 

I've put up a new RFC for review 

http://trac.osgeo.org/mapguide/wiki/MapGuideRfc133

Please review and provide any comments or feedback. Thanks. 

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/RFC-133-Additional-Stylization-Functions-tp5049107.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals


More information about the mapguide-internals mailing list