[mapguide-internals] Patch for ticket 2214: Cannot select features from a SQL Server Extended Feature class using RFC123 join optimizations

[Jackie Ng]

Hi All,

Attached is a patch for ticket 2214:

http://trac.osgeo.org/mapguide/ticket/2214

This patch fixes the following show-stopping issues with a SQL Server layer
that uses the RFC123 optimizations:

 1. The layer is not selectable, this is due to the FDO reader from the join
query not presenting a class definition with identity properties (therefore
un-selectable). We fix this by forcing a specific set of properties to be
identity when we return a converted MgClassDefinition from the
MgFeatureReader. We already have this identity property list as part of
building the original FDO join query, so it's a case of passing this list
down to the MgServerFeatureReader, and doing the MgClassDefinition
modifications if this list is present.

 2. Performing a select query with an explicit property list does not do
reverse-mapping of prefixed properties on the secondary class (as these
properties do not physically exist in the secondary class. They are the
aliased form of a [alias].[property] computed property expression. So we
need to reverse map to construct the [alias].[property] as
[prefixedPropertyName] FDO expression for plugging into our FDO join query)

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-2214-Cannot-select-features-from-a-SQL-Server-Extended-Feature-class-using-RFC123-js-tp5039939.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.