[mapguide-internals] Patch for ticket 2379 (GETMAPLEGENDIMAGE does not handle ShowInLegend style setting and multi-style scale ranges properly)

[Walt Welton-Lair]

It's still not 100% right...

With patch 4, if the collection contains a single unthemed CompositeTypeStyle and some other non-CompositeTypeStyles, then nTotalRules will be > 1 and bThemed will be set to true.  The legend will end up displaying the theme icon and not the icon from the single rule in the CompositeTypeStyle.

The peek-ahead code needs to compute both the total # of composite rules and the total # of non-composite rules.  If there are composite rules, then these take precedence and determine if the legend shows the themed or unthemed icon.  Otherwise the # of non-composite rules determines the icon.

Also, singleFTS needs to be set correctly when the collection has either a single CompositeTypeStyle rule or a single non-CompositeTypeStyle rule.  Currently singleFTS always ends up being set to the last FTS in the collection.  If the collection has just a single CompositeTypeStyle rule, then that type style isn't necessarily the last one.

Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Sunday, November 17, 2013 10:09 PM
To: mapguide-internals at lists.osgeo.org
Subject: Re: [mapguide-internals] Patch for ticket 2379 (GETMAPLEGENDIMAGE does not handle ShowInLegend style setting and multi-style scale ranges properly)

Hi Walt,

4th version of the patch posted
(http://trac.osgeo.org/mapguide/attachment/ticket/2379/2379_v4.patch)

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-2379-GETMAPLEGENDIMAGE-does-not-handle-ShowInLegend-style-setting-and-multi-style-s-tp5089060p5089580.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals