[mapguide-internals] Patch for ticket 2526 (MgUnclassifiedException thrown when QUERYMAPFEATURES request made with PERSIST=0)

[Walt Welton-Lair]

Hi Jackie,

In your patch the call to newSelection->SetMap() is now always being made, regardless of whether the selection set was saved.  Is that necessary?  Or does SetMap() only need to be called in the case of persist = true?

I'm not knowledgeable with the actual behavior of these APIs, but the change in the logic caught my attention.

Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Tuesday, March 10, 2015 12:28 PM
To: mapguide-internals at lists.osgeo.org
Subject: [mapguide-internals] Patch for ticket 2526 (MgUnclassifiedException thrown when QUERYMAPFEATURES request made with PERSIST=0)

Hi All,

I've attached a patch for ticket 2526

http://trac.osgeo.org/mapguide/ticket/2526

If you try to do a QUERYMAPFEATURES with PERSIST=0, it will throw a MgUnclassifiedException. This is because when the persist flag is false, a null MgSelection pointer is passed down to
MgHtmlController::CollectQueryMapFeaturesResult() because the MgSelection pointer is not properly assigned from the MgFeatureInformation when persist = false

This patch ensures CollectQueryMapFeaturesResult receives a non-null MgSelection pointer whether persist is true or false.

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-2526-MgUnclassifiedException-thrown-when-QUERYMAPFEATURES-request-made-with-PERSIST-tp5192598.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals