[mapguide-trac] #649: FeatureService.UpdateFeatures doesn't log errors and reports them as succesful

[MapGuide Open Source]

#649: FeatureService.UpdateFeatures doesn't log errors and reports them as
succesful
-----------------------------+----------------------------------------------
 Reporter:  zspitzer         |         Owner:       
     Type:  defect           |        Status:  new  
 Priority:  medium           |     Milestone:       
Component:  Feature Service  |       Version:  2.0.2
 Severity:  critical         |    Resolution:       
 Keywords:                   |   External_id:       
-----------------------------+----------------------------------------------
Changes (by zspitzer):

  * version:  2.0.1 => 2.0.2
  * summary:  FeatureService.UpdateFeatures doesn't log or throw errors =>
              FeatureService.UpdateFeatures doesn't log
              errors and reports them as succesful

Comment:

 Ok, test case attached, it uses the a feature source from the Sheboygan
 Samples. It will fail to make any changes, due to the SDF being marked as
 READ ONLY and the FeatureClass name is wrong ( should be Rail, is Rail3)

 Simply run the script, tweaking the user/pass if required.

 '''Current Behaviour:''' An error is returned in the result which must be
 manually inspected and the access.log reports the UpdateFeatures operation
 as being Successful.
 {{{
 UpdateFeatures.1.0.0:3(Library://Samples/Sheboygan/Data/Rail.FeatureSource,MgFeatureCommandCollection,false,)
 Success
 }}}
 '''Expected Behaviour:''' An error should be thrown (to be caught), the
 UpdateFeatures accesslog entry should be marked as Failure

 {{{
 UpdateFeatures.1.0.0:3(Library://Samples/Sheboygan/Data/Rail.FeatureSource,MgFeatureCommandCollection,false,)
 Failure
 }}}

 In addition the error message should be logged to error.log

 {{{
 An exception occurred in FDO component. Item 'Rail3' not found in
 collection
 Exception occurred in method MgServerUpdateFeatures.UpdateFeatures at line
 97 in
 file
 d:\buildforgeprojects\mapguide_open_source_v2.0\build_27.13\mgdev\server
 \src\services\feature\ServerUpdateFeatures.cpp
 }}}

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/649#comment:3>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals