[mapguide-trac] #1026: Prevent session timeout, and give better error messages (RFC 66)

MapGuide Open Source trac_mapguide at osgeo.org
Thu Jul 16 04:05:33 EDT 2009


#1026: Prevent session timeout, and give better error messages (RFC 66)
---------------------+------------------------------------------------------
 Reporter:  CXYS     |         Owner:  Tom Fukushima
     Type:  defect   |        Status:  reopened     
 Priority:  medium   |     Milestone:  2.2          
Component:  General  |       Version:  2.0.2        
 Severity:  major    |    Resolution:               
 Keywords:           |   External_id:               
---------------------+------------------------------------------------------
Comment (by ksgeograf):

 I have a few comments (copied from mailing list).

 1) The function name in line 455 is slightly misspelled, and referenced
 from line 435.
 2) The webAgent and clientAgent variables are now replicated in both
 ajaxmappane and mainframe.templ
 3) Same goes for the msie check in line 460
 4) Same goes for encodeComponent function in line 406
 5) Is the ParseLocalizedFloat function required? Does the server return
 a localized timeout value? And is it not supposed to be an int?
 6)  In line 434 you divide the time by 5 seconds, resulting in the
 number of checks pr. 5 seconds. You then pass this to setInterval.
 Should this not be:
 intervalID = window.setInterval(GetSeverSessionTimeout, num / 2.5)
 ? Or perhaps divided by 5 for faster checks?

 I'm not sure 2,3,4 is an issue, or it makes sense to move it around,
 but eventually someone will fix something in one place and leave
 the other one broken.

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1026#comment:10>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals


More information about the mapguide-trac mailing list