[mapguide-trac] #1026: Prevent session timeout, and give better error messages (RFC 66)

[MapGuide Open Source]

#1026: Prevent session timeout, and give better error messages (RFC 66)
---------------------+------------------------------------------------------
 Reporter:  CXYS     |         Owner:  Tom Fukushima
     Type:  defect   |        Status:  reopened     
 Priority:  medium   |     Milestone:  2.2          
Component:  General  |       Version:  2.0.2        
 Severity:  major    |    Resolution:               
 Keywords:           |   External_id:               
---------------------+------------------------------------------------------
Comment (by christinebao):

 Hi Kenneth,

    I considered to share the same functions between templates, in that way
 we don't duplicate code. However the problem is I can't find a suitable
 place to put these functions. It seems there are js files included by the
 templates and shared, such as browserdetect.js, but none of them are
 suitable for encodeComponent() and ParseLocalizedFloat(). What's your
 suggestion?


    I'll add comments for the ping server interval. Thanks for your
 suggestion.


 Thanks & regards,
 Christine

 Replying to [comment:14 ksgeograf]:
 > In (4) and (5), I think you can use the same function/variable name, but
 you are replicating the code. My comment was that this is hard to
 maintain, and -in a perfect world-, the two templ files would share the
 function, so it only has be maintained in one place.
 >
 > For (6), I read num / 5 * 1000 as: num / 5 seconds, which is not what is
 meant. I would suggest a comment like:[[BR]]
 > //Ping server 5 times each period. Timeout is returned in seconds.

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1026#comment:15>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals