[mapguide-trac] #1267: MgLayerBase::SetLayerDefinition should not change layer name

[MapGuide Open Source]

#1267: MgLayerBase::SetLayerDefinition should not change layer name
----------------------------+-----------------------------------------------
   Reporter:  tomfukushima  |       Owner:       
       Type:  defect        |      Status:  new  
   Priority:  medium        |   Milestone:       
  Component:  Web API       |     Version:  2.1.0
   Severity:  trivial       |    Keywords:       
External_id:  1289652.01    |  
----------------------------+-----------------------------------------------
 When working with a !MgLayerBase object, by default the layer gets a name
 derived from the resource ID of the layer definition.  This is good
 because a name other than "" is good and resource ID is as good as
 anything for a default.  The app developer can then use !SetName to change
 the name to something more to their liking. However, when
 MgLayerBase::!SetLayerDefinition is called, the layer name will be reset
 to the resource ID of the layer definition.  We need to remove this side
 effect for the cases when the developer has actually set the Name to
 something other than the default.

 Will need to check all code where !SetLayerDefinition is used to make sure
 that this functionality is not relied upon.

 If this is fixed it will cause a change in behavior to the API so a note
 must be added to the release notes.

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1267>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals