[mapguide-trac] #1443: MgProxyFeatureService::GetCapabilities is using a fixed api version 1.0.0

[MapGuide Open Source]

#1443: MgProxyFeatureService::GetCapabilities is using a fixed api version 1.0.0
------------------------+---------------------------------------------------
   Reporter:  wuma      |       Owner:  Mars Wu
       Type:  defect    |      Status:  new    
   Priority:  high      |   Milestone:         
  Component:  General   |     Version:  2.1.0  
   Severity:  critical  |    Keywords:         
External_id:  1342879   |  
------------------------+---------------------------------------------------
Changes (by brucedechant):

 * cc: brucedechant (added)


Old description:

> Steps:
> - Run WebTier tests:Feature/GetCapabilities. It will get the capabilites
> for a certain FDO provider.
> - Keep the initial values for the test page except for changing the
> version to be 2.0.0
> - Submit the request
>
> You will find the response is always for 1.0.0 instead of 2.0.0.
>
> The reaons is like following:
>
> **************
> MgByteReader* MgProxyFeatureService::GetCapabilities(CREFSTRING
> providerName, CREFSTRING connectionString)
> {
>     MgCommand cmd;
>     cmd.ExecuteCommand(m_connProp,                                  //
> Connection
>                        MgCommand::knObject,                         //
> Return type expected
>                        MgFeatureServiceOpId::GetCapabilities_Id,    //
> Command Code
>                        2,                                           // No
> of arguments
>                        Feature_Service,                             //
> Service Id
>                        BUILD_VERSION(1,0,0),                        //
> Operation version
>                        MgCommand::knString, &providerName,          //
> Argument#1
>                        MgCommand::knString, &connectionString,      //
> Argument#2
>                        MgCommand::knNone);                          //
> End of argument
>
>     SetWarning(cmd.GetWarningObject());
>
>     return (MgByteReader*)cmd.GetReturnValue().val.m_obj;
> }
> ************
>
> The version is a fixed one: BUILD_VERSION(1,0,0) instead of the requested
> version

New description:

 Steps:
 - Run !WebTier tests:Feature/GetCapabilities. It will get the capabilites
 for a certain FDO provider.
 - Keep the initial values for the test page except for changing the
 version to be 2.0.0
 - Submit the request

 You will find the response is always for 1.0.0 instead of 2.0.0.

 The reasons is like following:

 {{{
 MgByteReader* MgProxyFeatureService::GetCapabilities(CREFSTRING
 providerName, CREFSTRING connectionString)
 {
     MgCommand cmd;
     cmd.ExecuteCommand(m_connProp,                                  //
 Connection
                        MgCommand::knObject,                         //
 Return type expected
                        MgFeatureServiceOpId::GetCapabilities_Id,    //
 Command Code
                        2,                                           // No
 of arguments
                        Feature_Service,                             //
 Service Id
                        BUILD_VERSION(1,0,0),                        //
 Operation version
                        MgCommand::knString, &providerName,          //
 Argument#1
                        MgCommand::knString, &connectionString,      //
 Argument#2
                        MgCommand::knNone);                          // End
 of argument

     SetWarning(cmd.GetWarningObject());

     return (MgByteReader*)cmd.GetReturnValue().val.m_obj;
 }
 }}}

 The version is a fixed one: BUILD_VERSION(1,0,0) instead of the requested
 version.

--

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1443#comment:1>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals