[mapguide-trac] #1445: Watermark RFC implementation

MapGuide Open Source trac_mapguide at osgeo.org
Mon Sep 20 16:11:59 EDT 2010


#1445: Watermark RFC implementation
----------------------------+-----------------------------------------------
   Reporter:  brucedechant  |       Owner:     
       Type:  enhancement   |      Status:  new
   Priority:  medium        |   Milestone:  2.3
  Component:  Server        |     Version:     
   Severity:  blocker       |    Keywords:     
External_id:                |  
----------------------------+-----------------------------------------------

Comment(by brucedechant):

 Additional watermark cleanup

 Schema updates:
  * Improved documentation in the new schemas.
  * The !WatermarkDefinitionType element has a !WatermarkSource child
 element that contains the content for the watermark.  I've renamed
 !WatermarkSource to just Content.
  * The !WatermarkType element has child elements named
 !AppearanceOverrides and !PositionOverrides, but these names are wrong
 since in each case there's only a single object overriding things.  So I
 renamed the elements to !AppearanceOverride and !PositionOverride.  The
 !MdfModel and !MdfParser code was already using the new names.
  * A couple elements defined !ExtendedData child elements.  I renamed the
 child elements to !ExtendedData1 to be consistent with other uses of
 extended data in our schemas.

 !MdfModel updates:
  * Updated !WatermarkDefinition to account for the !WatermarkSource =>
 Content renaming.
  * Many of the new classes did not inherit from !MdfRootObject.  This
 based class provides support for handling unknown XML / extended data, and
 all !MdfModel classes should inherit from it.

 !MdfParser updates:
  * The new IOWatermark classes were incorrectly deleting references to
 !MdfModel objects in their destructors.  The lifetime of these !MdfModel
 objects is controlled by the !MdfModel classes, and not the IO classes.
  * Serialization of numerous optional schema properties / elements was not
 being done correctly.  The code needs to only serialize these properties /
 elements if they differ from the default value.
  * IOWatermarkInstance and IOWatermarkDefinition were not handling
 extended data correctly.
  * IOWatermarkDefinition::Write was not checking handling the case where
 the supplied version parameter was NULL.
  * Added additional comments to the new classes.

 r5151

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1445#comment:9>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals


More information about the mapguide-trac mailing list