[mapguide-trac] #1968: MgRaster serialization error

[MapGuide Open Source]

#1968: MgRaster serialization error
-------------------------------+--------------------------------------------
   Reporter:  jng              |       Owner:     
       Type:  defect           |      Status:  new
   Priority:  high             |   Milestone:  2.4
  Component:  Feature Service  |     Version:     
   Severity:  critical         |    Keywords:     
External_id:                   |  
-------------------------------+--------------------------------------------

Comment(by trevorwekel):

 Hi Jackie,  the patch is fine.  You might want to check your tab settings.
 The alignment looks off in the patch.

 You may also want to add a dynamic cast to !MgSerializable from !MgObject
 in MgStreamWriter::WriteObject, check for NULL, and throw an exception.

 The blind cast from !MgObject to !MgSerializable is bad.  Ideally,
 !WriteObject should be taking an !MgSerializable.  Unfortunately, that
 change would impact !MgCommand logic and may be too invasive.  Maybe a 2.5
 item.

 I did a search in the code base for WriteObject taking non-serializable
 arguments.  I didn't see any other instances of this.  Near as I can tell,
 this has been in here for years.

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1968#comment:1>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals