[mapserver-commits] [mapserver/mapserver] 738ea6: mapxbase: simplify fieldname assignment to pszFInf...

Fri Sep 7 05:41:20 PDT 2018

  Branch: refs/heads/master
  Home:   https://github.com/mapserver/mapserver
  Commit: 738ea6d45e31c8c6e1f5f2c3a06473b378a66709
      https://github.com/mapserver/mapserver/commit/738ea6d45e31c8c6e1f5f2c3a06473b378a66709
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapxbase.c

  Log Message:
  -----------
  mapxbase: simplify fieldname assignment to pszFInfo

  Commit: 23893139adbe042eb944b7ee62ae7067f1600c8f
      https://github.com/mapserver/mapserver/commit/23893139adbe042eb944b7ee62ae7067f1600c8f
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapxbase.c

  Log Message:
  -----------
  Simplify msDBFWriteAttribute to get rid of compiler warnings in latest GCC.

Latest GCC shows these warnings when compiling release build:
warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
warning: ‘strncpy’ output may be truncated copying between 0 and 39 bytes from a string of length 39 [-Wstringop-truncation]
warning: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]

In msDBFWriteAttribute we can replace strncpy with memcpy since we already check for the string length and
we don't want the strncpy capability of writing extra \0 characters.

Also replace the 2 snprintf calls (one for the specific format, and one for the value) with a single one.

As snprintf can handle 0 precision numbers just fine, we don't need a separate branch for that either.
NOTE, this does change the rounding for doubles whose field precision is set to 0.
Before 90.9 would be converted to 90, with the new code it would become 91.

  Commit: 0f3a648fc3d74d34baf928096c0b8ebd1ebc8150
      https://github.com/mapserver/mapserver/commit/0f3a648fc3d74d34baf928096c0b8ebd1ebc8150
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mappostgis.c

  Log Message:
  -----------
  mappostgis: fix forgotten pointer dereference

  Commit: b27976f2dca4958cbe94088d55011c69b1c1b869
      https://github.com/mapserver/mapserver/commit/b27976f2dca4958cbe94088d55011c69b1c1b869
  Author: Even Rouault <even.rouault at mines-paris.org>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapxbase.c

  Log Message:
  -----------
  Merge pull request #5647 from gogglesguy/mapxbase-simplify-write-attribute

Simplify msDBFWriteAttribute to get rid of compiler warnings

  Commit: 636394c7e205ec6bdb9d8c3beb8edb45a39722c0
      https://github.com/mapserver/mapserver/commit/636394c7e205ec6bdb9d8c3beb8edb45a39722c0
  Author: Even Rouault <even.rouault at mines-paris.org>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mappostgis.c

  Log Message:
  -----------
  Merge pull request #5648 from gogglesguy/mappostgis-pointer-compare

mappostgis: fix forgotten pointer dereference

  Commit: a2f08817428c9445342fab000ea0b01b855a0480
      https://github.com/mapserver/mapserver/commit/a2f08817428c9445342fab000ea0b01b855a0480
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapwms.c

  Log Message:
  -----------
  mapwms: fix forgotten if braces for commit c8190e5f3d27f0d93648c6fa7e7c6671ce729402

Compiler warned about misleading indent

  Commit: 9b95631eeff38ee7c29a2d4237befc3417915a6a
      https://github.com/mapserver/mapserver/commit/9b95631eeff38ee7c29a2d4237befc3417915a6a
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapwms.c

  Log Message:
  -----------
  Merge pull request #5649 from gogglesguy/mapwms-fix-forgotten-braces

mapwms: fix forgotten if braces

  Commit: c86b5e5bfbe386621e08f21e8f85e3f16fc0a340
      https://github.com/mapserver/mapserver/commit/c86b5e5bfbe386621e08f21e8f85e3f16fc0a340
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapogcsld.c

  Log Message:
  -----------
  mapogcsld: fix potential overflow when writing hexcolor in the unlikely case color components are bigger than 255

  Commit: d18302baca4990fd4540784117152feed5560c7d
      https://github.com/mapserver/mapserver/commit/d18302baca4990fd4540784117152feed5560c7d
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapwcs.c
    M mapwcs20.c

  Log Message:
  -----------
  mapwcs: use large enough output buffer for snprintf

  Commit: 0bf81bb61f8354dbf3cc4c1f68fcf0182df6405d
      https://github.com/mapserver/mapserver/commit/0bf81bb61f8354dbf3cc4c1f68fcf0182df6405d
  Author: Sander Jansen <s.jansen at gmail.com>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapwcs20.c

  Log Message:
  -----------
  mapwcs20: keep compiler happy about (im)possible use of uninitialized memory

  Commit: 040d9ce1c7f72e7caf2eae8a15bb0ece7eb2828c
      https://github.com/mapserver/mapserver/commit/040d9ce1c7f72e7caf2eae8a15bb0ece7eb2828c
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M mapogcsld.c

  Log Message:
  -----------
  Merge pull request #5650 from gogglesguy/mapogcsld-fix-potential-overflow

mapogcsld: fix potential overflow when writing hexcolor

  Commit: a53a72d1c5bb8c7f633fead39d39ec5ca80614ba
      https://github.com/mapserver/mapserver/commit/a53a72d1c5bb8c7f633fead39d39ec5ca80614ba
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M COMMITERS

  Log Message:
  -----------
  Update COMMITERS

Adding row for Seth Girvin

  Commit: 0ebd2b60453fa78068e1a8b2aedfb99a5b1b8918
      https://github.com/mapserver/mapserver/commit/0ebd2b60453fa78068e1a8b2aedfb99a5b1b8918
  Author: Oliver Tonnhofer <olt at bogosoft.com>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    A msautotest/renderers/labels-wrap.map
    M textlayout.c

  Log Message:
  -----------
  Fix label wrap (#5612) and wrap at ZERO WIDTH SPACE (#5613)

  Commit: e26bf0ec049f5617bef3de4bfb1643a9d473777e
      https://github.com/mapserver/mapserver/commit/e26bf0ec049f5617bef3de4bfb1643a9d473777e
  Author: Oliver Tonnhofer <olt at bogosoft.com>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    A msautotest/renderers/expected/labels-wrap.png

  Log Message:
  -----------
  Add expected image for labels-wrap test

  Commit: dbd43dd54969d1df798c2f0598f37d9dfc9a750b
      https://github.com/mapserver/mapserver/commit/dbd43dd54969d1df798c2f0598f37d9dfc9a750b
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M mapmvt.c

  Log Message:
  -----------
  Fixed clipping error for point layers (#5652).

  Commit: d24e96a07c412fbc9b6c9234a7bc8b79faf9807e
      https://github.com/mapserver/mapserver/commit/d24e96a07c412fbc9b6c9234a7bc8b79faf9807e
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-29 (Wed, 29 Aug 2018)

  Changed paths:
    M mapmvt.c

  Log Message:
  -----------
  Merge pull request #5655 from sdlime/mvt-points

Fixed clipping error for point layers (#5652).

  Commit: cfa903b37c4d053bc35082cfd58e408544dee9cd
      https://github.com/mapserver/mapserver/commit/cfa903b37c4d053bc35082cfd58e408544dee9cd
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    A msautotest/renderers/expected/labels-wrap.png
    A msautotest/renderers/labels-wrap.map
    M textlayout.c

  Log Message:
  -----------
  Merge pull request #5634 from olt/label-wrap-fix

Fix label wrap (#5612) and wrap at ZERO WIDTH SPACE (#5613)

  Commit: 9a5494219a093de1086375c1b9613d7b2a087656
      https://github.com/mapserver/mapserver/commit/9a5494219a093de1086375c1b9613d7b2a087656
  Author: Steve Lime <steve.lime at state.mn.us>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M mapwcs.c
    M mapwcs20.c

  Log Message:
  -----------
  Merge pull request #5651 from gogglesguy/mapwcs-fixes

mapwcs: fixes to uninitialized memory / snprintf

  Commit: 5379636056e057dbe6edc9e4d9086ae223f0a512
      https://github.com/mapserver/mapserver/commit/5379636056e057dbe6edc9e4d9086ae223f0a512
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2018-09-07 (Fri, 07 Sep 2018)

  Changed paths:
    M appveyor.yml

  Log Message:
  -----------
  appveyor.yml: backport master changes related to backslashes

  Commit: 9594c2f30b6667a8109bbdb72cba79a0ca9f0ea6
      https://github.com/mapserver/mapserver/commit/9594c2f30b6667a8109bbdb72cba79a0ca9f0ea6
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2018-09-07 (Fri, 07 Sep 2018)

  Changed paths:
    M mapscript/python/CMakeLists.txt

  Log Message:
  -----------
  CMake Python mapscript: avoid cmake 3.12 error with get_target_property LOCATION

  Commit: b805b5bb60641d60eee6161a7ac5a366c8b7d3f4
      https://github.com/mapserver/mapserver/commit/b805b5bb60641d60eee6161a7ac5a366c8b7d3f4
  Author: Even Rouault <even.rouault at mines-paris.org>
  Date:   2018-09-07 (Fri, 07 Sep 2018)

  Changed paths:
    M appveyor.yml
    M mapscript/python/CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #5661 from rouault/appveyor_7_2

appveyor.yml: backport master changes related to backslashes

  Commit: 8391eaf7726832ace8c72d06f3e3912af87bf92c
      https://github.com/mapserver/mapserver/commit/8391eaf7726832ace8c72d06f3e3912af87bf92c
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2018-09-07 (Fri, 07 Sep 2018)

  Changed paths:
    M COMMITERS
    M mapmvt.c
    M mapogcsld.c
    M mappostgis.c
    M mapwcs.c
    M mapwcs20.c
    M mapwms.c
    M mapxbase.c
    A msautotest/renderers/expected/labels-wrap.png
    A msautotest/renderers/labels-wrap.map
    M textlayout.c

  Log Message:
  -----------
  Merge branch 'branch-7-2' into master_fix_appveyor

  Commit: d50430b959d91ec55bb7a0954ae5bb86b0ec43ec
      https://github.com/mapserver/mapserver/commit/d50430b959d91ec55bb7a0954ae5bb86b0ec43ec
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2018-09-07 (Fri, 07 Sep 2018)

  Changed paths:
    M .travis.yml
    M mapscript/python/CMakeLists.txt

  Log Message:
  -----------
  mapscript/python/CMakeLists.txt: fix for appveyor and travis

Compare: https://github.com/mapserver/mapserver/compare/04f8fc0a16fc...d50430b959d9
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.