[mapserver-commits] [MapServer/MapServer] 4fd204: Fix Coverity Scan false positive about freeing map...

[Jeff McKenna]

  Branch: refs/heads/main
  Home:   https://github.com/MapServer/MapServer
  Commit: 4fd204bcdfb25cff3d858777255c2147cfe7e5ce
      https://github.com/MapServer/MapServer/commit/4fd204bcdfb25cff3d858777255c2147cfe7e5ce
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M maplabel.c
    M maplegend.c
    M mapserver.h

  Log Message:
  -----------
  Fix Coverity Scan false positive about freeing map->legend.label (CID 1503451, 1503355)


  Commit: a48e5a4478208879d67ff9fedba26d28185d7466
      https://github.com/MapServer/MapServer/commit/a48e5a4478208879d67ff9fedba26d28185d7466
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapserver.h

  Log Message:
  -----------
  Add IGNORE_RET_VAL() inline function


  Commit: 94f3db38888884759192e4dd54943bce0a6a1a11
      https://github.com/MapServer/MapServer/commit/94f3db38888884759192e4dd54943bce0a6a1a11
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapwms.cpp

  Log Message:
  -----------
  Explicitly ignore return value (CID 1503593)


  Commit: d93612635a8c2674f7f9342eaee1a4d0d25a1918
      https://github.com/MapServer/MapServer/commit/d93612635a8c2674f7f9342eaee1a4d0d25a1918
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapshape.c

  Log Message:
  -----------
  Explicitly ignore return value (CID 1503578)


  Commit: 8dc41040c30a2df2583d80a2fbe4e74166fab4c9
      https://github.com/MapServer/MapServer/commit/8dc41040c30a2df2583d80a2fbe4e74166fab4c9
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapshape.c

  Log Message:
  -----------
  msSHPReadAllocateBuffer(): use correct realloc() pattern and validate size (CID 1503560)


  Commit: 94632e1de92e4eab2c91aeda7b05a78724e3ee38
      https://github.com/MapServer/MapServer/commit/94632e1de92e4eab2c91aeda7b05a78724e3ee38
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapuvraster.c

  Log Message:
  -----------
  uvraster: remove useless ceil() (CID 1503549)


  Commit: 70295d6d49e6d2d6204084a5874d274d27de5726
      https://github.com/MapServer/MapServer/commit/70295d6d49e6d2d6204084a5874d274d27de5726
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M renderers/agg/src/agg_font_freetype.cpp

  Log Message:
  -----------
  agg_font_freetype.cpp: fix incorrect use of memcpy() (CID 1503528)


  Commit: 3c0b423941e5ce452f4834cc3027f12397c86f60
      https://github.com/MapServer/MapServer/commit/3c0b423941e5ce452f4834cc3027f12397c86f60
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapwms.cpp

  Log Message:
  -----------
  msWMSApplyFilter(): add assertions to avoid false positive warning about nullptr dereference (CID 1503489)


  Commit: cbf0f8dfee26d2961a5a1863c0a733b6b4dc8b24
      https://github.com/MapServer/MapServer/commit/cbf0f8dfee26d2961a5a1863c0a733b6b4dc8b24
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapogcsld.c

  Log Message:
  -----------
  msSLDParseOgcExpression(): make it obvious that no nullptr dereferencing will occur (CID 1503465)


  Commit: 2477200ad38c2f125cbb9d8f932d5e9cd7abccfa
      https://github.com/MapServer/MapServer/commit/2477200ad38c2f125cbb9d8f932d5e9cd7abccfa
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapwmslayer.c

  Log Message:
  -----------
  msPrepareWMSLayerRequest(): avoid false positive warning about nullptr dereference (CID 1503462)


  Commit: 6d0c6a44a5218e8febdbc3fcba291e202d40b891
      https://github.com/MapServer/MapServer/commit/6d0c6a44a5218e8febdbc3fcba291e202d40b891
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapwfs.cpp

  Log Message:
  -----------
  msWFSWriteGeometryElement(): remove useless nullptr check (CID 1503443)


  Commit: 74b8a7ca5ef0fb9274cf7468558756b393ab7474
      https://github.com/MapServer/MapServer/commit/74b8a7ca5ef0fb9274cf7468558756b393ab7474
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M maptemplate.c

  Log Message:
  -----------
  maptemplate.c: add assert() to avoid warning about nullptr deref (CID 1503429)


  Commit: ad91457e98d7a403279416b6d594ac00d5c8b540
      https://github.com/MapServer/MapServer/commit/ad91457e98d7a403279416b6d594ac00d5c8b540
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-04-24 (Sat, 24 Apr 2021)

  Changed paths:
    M mapwcs20.cpp

  Log Message:
  -----------
  msWCSGetCoverage20(): remove dead branch (CID 1503406)


  Commit: e306cd034fa4d7b2c9e60d5ecb923e8693025e77
      https://github.com/MapServer/MapServer/commit/e306cd034fa4d7b2c9e60d5ecb923e8693025e77
  Author: Jeff McKenna <jmckenna at gatewaygeomatics.com>
  Date:   2021-04-26 (Mon, 26 Apr 2021)

  Changed paths:
    M maplabel.c
    M maplegend.c
    M mapogcsld.c
    M mapserver.h
    M mapshape.c
    M maptemplate.c
    M mapuvraster.c
    M mapwcs20.cpp
    M mapwfs.cpp
    M mapwms.cpp
    M mapwmslayer.c
    M renderers/agg/src/agg_font_freetype.cpp

  Log Message:
  -----------
  Merge pull request #6311 from rouault/coverity_scan_fixes

Another batch of coverity scan fixes


Compare: https://github.com/MapServer/MapServer/compare/e296cb15e9df...e306cd034fa4