[mapserver-commits] [MapServer/MapServer] c8d57e: shptreetst.c: avoid Coverity warning (CID 1503520)

Sun May 16 04:17:54 PDT 2021

  Branch: refs/heads/main
  Home:   https://github.com/MapServer/MapServer
  Commit: c8d57eff665dba7905d42e7ae9fca4915771deda
      https://github.com/MapServer/MapServer/commit/c8d57eff665dba7905d42e7ae9fca4915771deda
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M shptreetst.c

  Log Message:
  -----------
  shptreetst.c: avoid Coverity warning (CID 1503520)


  Commit: 61d7ce0e08cf29e82cb1907c63d68ee3b2ce65d6
      https://github.com/MapServer/MapServer/commit/61d7ce0e08cf29e82cb1907c63d68ee3b2ce65d6
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maphttp.c

  Log Message:
  -----------
  maphttp.c: silence Coverity warning (CID 1503504)


  Commit: 0abd3d14d4cad947858b87e9bbd623787fbe6bd6
      https://github.com/MapServer/MapServer/commit/0abd3d14d4cad947858b87e9bbd623787fbe6bd6
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapogcsld.c

  Log Message:
  -----------
  mapogcsld.c: check return value of msInitializeVirtualTable() (CID 1503501)


  Commit: f1669f8dfd9073a4d76fa4cb91547e79a41172b9
      https://github.com/MapServer/MapServer/commit/f1669f8dfd9073a4d76fa4cb91547e79a41172b9
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapchart.c

  Log Message:
  -----------
  mapchart.c: remove a useless for construct (CID 1503475)


  Commit: ea5318425c3ef3ba1fb3e4d822680afab845d1f2
      https://github.com/MapServer/MapServer/commit/ea5318425c3ef3ba1fb3e4d822680afab845d1f2
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapwcs20.cpp

  Log Message:
  -----------
  mapwcs20.cpp: check return value of msStringParseInteger() (CID 1503469)


  Commit: 5c901f8ce372d517d69d28c35259ad31a1c55c33
      https://github.com/MapServer/MapServer/commit/5c901f8ce372d517d69d28c35259ad31a1c55c33
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapfile.c

  Log Message:
  -----------
  mapfile.c: silence warning (CID 1503468)


  Commit: 6e58de1eb3ece4be758129353c9fd984c774c07f
      https://github.com/MapServer/MapServer/commit/6e58de1eb3ece4be758129353c9fd984c774c07f
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapimagemap.c

  Log Message:
  -----------
  msDrawMarkerSymbolIM(): cast to appropriate type (CID 1503401)


  Commit: ce8c9d6a147f3868c7a0ef099aacdee1fa245a21
      https://github.com/MapServer/MapServer/commit/ce8c9d6a147f3868c7a0ef099aacdee1fa245a21
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapraster.c

  Log Message:
  -----------
  msGetClass_String(): rewrite loop in a less confusing way to solve CID 1503394


  Commit: 99d55e1281d358ff2d2592b264c82903905626b6
      https://github.com/MapServer/MapServer/commit/99d55e1281d358ff2d2592b264c82903905626b6
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapgdal.c

  Log Message:
  -----------
  msSaveImageGDAL(): avoid false positive warning about nullptr deref (CID 1503386)


  Commit: d1c79af976251b0a8d5bb8fbc7ac497253ea7dbb
      https://github.com/MapServer/MapServer/commit/d1c79af976251b0a8d5bb8fbc7ac497253ea7dbb
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapchart.c

  Log Message:
  -----------
  msDrawChartLayer(): remove useless nullptr check (CID 1503362)


  Commit: 897812f8a20427526949cf0100a879760a7972dd
      https://github.com/MapServer/MapServer/commit/897812f8a20427526949cf0100a879760a7972dd
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maphttp.c

  Log Message:
  -----------
  maphttp.c: avoid warnings about unchecked return value of curl_easy_setopt() (CID 1503358)


  Commit: f7b91d033ebb0066242a7e8ac22c70887d5d047e
      https://github.com/MapServer/MapServer/commit/f7b91d033ebb0066242a7e8ac22c70887d5d047e
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapwfs.cpp

  Log Message:
  -----------
  msWFSRetrieveFeatures(): avoid false positive warning about nullptr deref (CID 1503340)


  Commit: ac2cabfd4e87b02dcb3d3d3d4b0d64f62770ca81
      https://github.com/MapServer/MapServer/commit/ac2cabfd4e87b02dcb3d3d3d4b0d64f62770ca81
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapprimitive.c

  Log Message:
  -----------
  Rename/switch variable to be consistent with argument names of compute_retry_offset() (CID 1503339)


  Commit: 23cc3bf481f0effc9f2553b7d735e9f2c4efa820
      https://github.com/MapServer/MapServer/commit/23cc3bf481f0effc9f2553b7d735e9f2c4efa820
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapwms.cpp

  Log Message:
  -----------
  mapwms.c: avoid likely false positive warning about div by zero (CID 1503334)


  Commit: 05d205a5361643f046df9ee85b489a73c17523c3
      https://github.com/MapServer/MapServer/commit/05d205a5361643f046df9ee85b489a73c17523c3
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapwfs.cpp

  Log Message:
  -----------
  mapwfs.cpp: remove useless nullptr check (CID 1503326)


  Commit: 496023d71751ab21abd10252cdd24dcafa75a3ed
      https://github.com/MapServer/MapServer/commit/496023d71751ab21abd10252cdd24dcafa75a3ed
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapmvt.c

  Log Message:
  -----------
  msMVTWriteTile(): fix test condition (CID 1503319)


  Commit: f8e8c52ae2784f81f69fd5e33860b95b2c9ef645
      https://github.com/MapServer/MapServer/commit/f8e8c52ae2784f81f69fd5e33860b95b2c9ef645
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mappostgis.cpp

  Log Message:
  -----------
  msPostGISReadShape(): avoid dead code warning (CID 1503309)


  Commit: f6d9b4e5265a9c0adc99bc73e9df8dce59035461
      https://github.com/MapServer/MapServer/commit/f6d9b4e5265a9c0adc99bc73e9df8dce59035461
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maptime.c

  Log Message:
  -----------
  msValidateTimeValue(): avoid identical code in then and else blocks (CID 1503270)


  Commit: 1f81ea8a65a2b8f2db1f84cb7307a1cc5dc8d444
      https://github.com/MapServer/MapServer/commit/1f81ea8a65a2b8f2db1f84cb7307a1cc5dc8d444
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapproject.c

  Log Message:
  -----------
  mapproject.c: avoid false positive warning about dead code (CID 1503265)


  Commit: 4c33c69feb88b71959c583847a615bd542ff5575
      https://github.com/MapServer/MapServer/commit/4c33c69feb88b71959c583847a615bd542ff5575
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mappostgis.cpp

  Log Message:
  -----------
  wkbConvCollectionToShape(): add some validation (CID 1503262)


  Commit: 364ffe1b8e8ec1db9791ee77c171870ab1054f51
      https://github.com/MapServer/MapServer/commit/364ffe1b8e8ec1db9791ee77c171870ab1054f51
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapproject.c

  Log Message:
  -----------
  msProjectShapeShouldDoLineCutting(): silence false positive warning (CID 1503239)


  Commit: c538dd48b6560105ee3e715676e51d8918fd9ca0
      https://github.com/MapServer/MapServer/commit/c538dd48b6560105ee3e715676e51d8918fd9ca0
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapwms.cpp

  Log Message:
  -----------
  mapwms.cpp: avoid false positive warning about copy and paste error (CID 1503220)


  Commit: f98c3336e322b8ab255c542a7471652945bb58e1
      https://github.com/MapServer/MapServer/commit/f98c3336e322b8ab255c542a7471652945bb58e1
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maputfgrid.h

  Log Message:
  -----------
  maputfgrid.h: initialize member variable (CID 1194603)


  Commit: 22a0d295686c20dc5176dfa37f3769a2813efab1
      https://github.com/MapServer/MapServer/commit/22a0d295686c20dc5176dfa37f3769a2813efab1
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maplabel.c

  Log Message:
  -----------
  msAddLabel(): add assertion against potential nullptr deref (CID 1194593)


  Commit: 3300882f958d281d56fb8b1015479073451ca025
      https://github.com/MapServer/MapServer/commit/3300882f958d281d56fb8b1015479073451ca025
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maplabel.c

  Log Message:
  -----------
  msCopyTextSymbol(): rewrite checks in an equivalent but clearer way (CID 1194592)


  Commit: 0d58e6e8532c46b0fa86b2d37646f6440999f61e
      https://github.com/MapServer/MapServer/commit/0d58e6e8532c46b0fa86b2d37646f6440999f61e
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maprendering.c

  Log Message:
  -----------
  getTile(): remove dead code (CID 1194589)


  Commit: 35d4084ede678cf107b0d111c5e82e586d82e1e2
      https://github.com/MapServer/MapServer/commit/35d4084ede678cf107b0d111c5e82e586d82e1e2
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapwfs11.cpp

  Log Message:
  -----------
  msWFSDumpLayer11(): remove dead code (CID 1175264)


  Commit: 55dcfd66f3f1b837e8d44f6257fcfa66ca0369ba
      https://github.com/MapServer/MapServer/commit/55dcfd66f3f1b837e8d44f6257fcfa66ca0369ba
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapxmp.c

  Log Message:
  -----------
  msXmpWrite(): avoid false positive warning about nullptr deref (CID 1175242)


  Commit: 359c4a2c6cd0b89ee48d512f9d52658e55f453df
      https://github.com/MapServer/MapServer/commit/359c4a2c6cd0b89ee48d512f9d52658e55f453df
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M maptemplate.c

  Log Message:
  -----------
  maptemplate.c: silence false positive warning (CID 1174974)


  Commit: 1bd99d2b4a377d59a5f3e918e6c21337d2c71fc0
      https://github.com/MapServer/MapServer/commit/1bd99d2b4a377d59a5f3e918e6c21337d2c71fc0
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-05-15 (Sat, 15 May 2021)

  Changed paths:
    M mapdraw.c

  Log Message:
  -----------
  mapwms.cpp: avoid false positive warning about nullptr deref (CID 1174977)


  Commit: c862b04cf690091995df40139a6be77a2ff72bce
      https://github.com/MapServer/MapServer/commit/c862b04cf690091995df40139a6be77a2ff72bce
  Author: Jeff McKenna <jmckenna at gatewaygeomatics.com>
  Date:   2021-05-16 (Sun, 16 May 2021)

  Changed paths:
    M mapchart.c
    M mapdraw.c
    M mapfile.c
    M mapgdal.c
    M maphttp.c
    M mapimagemap.c
    M maplabel.c
    M mapmvt.c
    M mapogcsld.c
    M mappostgis.cpp
    M mapprimitive.c
    M mapproject.c
    M mapraster.c
    M maprendering.c
    M maptemplate.c
    M maptime.c
    M maputfgrid.h
    M mapwcs20.cpp
    M mapwfs.cpp
    M mapwfs11.cpp
    M mapwms.cpp
    M mapxmp.c
    M shptreetst.c

  Log Message:
  -----------
  Merge pull request #6330 from rouault/coverity_scan_fixes

Another batch of Coverity scan fixes


Compare: https://github.com/MapServer/MapServer/compare/9d086cacc2df...c862b04cf690