[mapserver-commits] [MapServer/MapServer] 009ca2: mapogcapi: catch std::runtime_error by reference

Even Rouault noreply at github.com
Fri Oct 8 06:21:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/MapServer/MapServer
  Commit: 009ca21fa7d9027e8ad84022b6ddb695fb70a935
      https://github.com/MapServer/MapServer/commit/009ca21fa7d9027e8ad84022b6ddb695fb70a935
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapogcapi.cpp

  Log Message:
  -----------
  mapogcapi: catch std::runtime_error by reference

Avoids implicit copies while catching the exception.


  Commit: 8c9ada0b8ec50b74b7f80f6dfc61b3a26172536c
      https://github.com/MapServer/MapServer/commit/8c9ada0b8ec50b74b7f80f6dfc61b3a26172536c
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapowscommon.h

  Log Message:
  -----------
  mapowscommon.h: move "extern C" down, after the #includes

Fixes "error: template with C linkage" because libxml2 includes libicu
which features C++ templates when compiled with a C++ compiler.


  Commit: a913c49b8a1d042ce10c91bf837676ac193b9720
      https://github.com/MapServer/MapServer/commit/a913c49b8a1d042ce10c91bf837676ac193b9720
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapagg.cpp
    M mapaxisorder.h
    M maperror.c
    M mappostgis.h
    M mapservutil.c
    M maptemplate.c
    M mapthread.c
    M maputfgrid.cpp
    M strptime.c

  Log Message:
  -----------
  maperror, ...: add missing "const" to global variables

Allows the compiler to move the variables to ".rodata" where they will
be write-protected.


  Commit: 62eb83a9b89b7c1375226b6756c81976615a6327
      https://github.com/MapServer/MapServer/commit/62eb83a9b89b7c1375226b6756c81976615a6327
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapshape.c

  Log Message:
  -----------
  mapshape: remove redundant NULL check

The SfRealloc() return value has already been checked, and it's
impossible for pabyRec to be still NULL.


  Commit: cad0d19445758ba9e5680a38493c056beb5d98f4
      https://github.com/MapServer/MapServer/commit/cad0d19445758ba9e5680a38493c056beb5d98f4
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapshape.c
    M mapshape.h

  Log Message:
  -----------
  mapshape: make internal SHX functions static

They are only used from within mapshape.c.


  Commit: 359b16012ac6f558b1e35ce54ed8cdb48f75b334
      https://github.com/MapServer/MapServer/commit/359b16012ac6f558b1e35ce54ed8cdb48f75b334
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapshape.c

  Log Message:
  -----------
  mapshape: eliminate redundant msSHXReadSize() calls


  Commit: dfc45592d00d8db76922cace10afe8c8fea8fcfd
      https://github.com/MapServer/MapServer/commit/dfc45592d00d8db76922cace10afe8c8fea8fcfd
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapshape.c

  Log Message:
  -----------
  mapshape: msSHPReadAllocateBuffer() returns buffer

This avoids lots of memory accesses, because the pointer is now in a
local variable.  Previously, the disassembly looked very clumsy,
because each occurrence of "psSHP->pabyRec" needed to reload the
register from RAM.


  Commit: 4334114a74fe7155f735407ce62867e8039a4a9e
      https://github.com/MapServer/MapServer/commit/4334114a74fe7155f735407ce62867e8039a4a9e
  Author: Max Kellermann <max at duempel.org>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapshape.c
    M maptree.c

  Log Message:
  -----------
  mapshape, maptree: determine endianess at compile time

Removing the unnecessary runtime checks and the byte swapping code
reduces the library size by 5 kB.


  Commit: 430e968fc6b763a0bebf1f713a57762ffc6fae71
      https://github.com/MapServer/MapServer/commit/430e968fc6b763a0bebf1f713a57762ffc6fae71
  Author: Max Kellermann <max.kellermann at gmail.com>
  Date:   2021-10-07 (Thu, 07 Oct 2021)

  Changed paths:
    M mapshape.c

  Log Message:
  -----------
  mapshape: move duplicate code to ReadRect()


  Commit: cc714db386ce9bad1b440e7cef7d03eb336beb98
      https://github.com/MapServer/MapServer/commit/cc714db386ce9bad1b440e7cef7d03eb336beb98
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M mapagg.cpp
    M mapaxisorder.h
    M maperror.c
    M mapogcapi.cpp
    M mapowscommon.h
    M mappostgis.h
    M mapservutil.c
    M mapshape.c
    M mapshape.h
    M maptemplate.c
    M mapthread.c
    M maptree.c
    M maputfgrid.cpp
    M strptime.c

  Log Message:
  -----------
  Merge pull request #6423 from MaxKellermann/code_cleanup1

Some code cleanup and micro-optimizations


Compare: https://github.com/MapServer/MapServer/compare/af4b69606766...cc714db386ce


More information about the mapserver-commits mailing list