[mapserver-commits] [MapServer/MapServer] 42e6ac: Coverity Scan fixes (#6887)

[Even Rouault]

  Branch: refs/heads/main
  Home:   https://github.com/MapServer/MapServer
  Commit: 42e6acf009febbd76f035d5d7563674d13588b3b
      https://github.com/MapServer/MapServer/commit/42e6acf009febbd76f035d5d7563674d13588b3b
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M mapdraw.c
    M maplegend.c
    M mapogcapi.cpp
    M mapogcfilter.cpp
    M mapogcsld.c
    M mapogcsos.c
    M mappostgis.cpp
    M mapprimitive.c
    M maptemplate.c
    M mapwfs.cpp

  Log Message:
  -----------
  Coverity Scan fixes (#6887)

* offsetAndTest(): initialize .m member (CID 1514358)

* arcStrokeCircle(): initialize .m member (CID 1514356)

* msLineLabelPath(): make it (hopefully) obvious to Coverity Scan there's no memleak (CID 1503574)

* msDrawLegend(): make it (hopefully) obvious to Coverity Scan there's no memleak (CID 1175162)

* msSOSAddMemberNode(): avoid warning about dereference after null check (CID 1518796)

* processIcon(): avoid setting pointer to unused value (CID 1561169)

* generateLegendTemplate(): localize nLegendOrder variable and avoid useless 0 setting (CID 1561168)

* processExtentTag(): avoid setting variables and not reading them back afterwards (CID 1561167)

* processShpxyTag(): avoid setting variables and not reading them back afterwards (CID 1561166)

* findTag(): fix const'ness

* processApiRequest(): use std::move() to avoid copy (CID 1561162)

* msWFSRetrieveFeatures(): avoid setting pointer to unused value (CID 1561157)

* msSOSGetObservation(): localize variable to avoid useless NULL setting (CID 1561155)

* processShplabelTag(): avoid setting variables and not reading them back afterwards (CID 1561150)

* FLTApplyExpressionToLayer(): localize variable to avoid useless NULL setting (CID 1561144)

* msSLDGeneratePolygonSLD(): localize variable to avoid useless NULL setting (CID 1561142)

* processApiRequest(): use std::move() to avoid copy (CID 1561139)

* processItemTag(): avoid setting variables and not reading them back afterwards (CID 1561137)

* processIfTag(): avoid setting variables and not reading them back afterwards (CID 1561136)