[Mapserver-dev] cvs segfaults!

[Vincent Schut]

I think there is a typo in cgiutil.c, line 67: 's == NULL' should be 's != 
NULL' : (other lines just there for reference)

65	// check for any available cookies
66	  s = getenv("HTTP_COOKIE");
67	  if(s == NULL) {
68	    for(x=0;s[0] != '\0';x++) {

should be:

65	// check for any available cookies
66	  s = getenv("HTTP_COOKIE");
67	  if(s != NULL) {
68	    for(x=0;s[0] != '\0';x++) {

If you change this, the segfault disapears.
Which is logical if you check what 's' actually is. I think, if there is no 
cookie, so s == NULL, the cookie-code that follows line 67 should NOT be 
run...

I'm sorry but I don't have any experience with diff, and this is my first 
debugging :-) so I don't attach a patch... But changing one line by hand 
shouldn't be too hard :)

Regards,
Vincent.

On Monday 19 May 2003 09:02, m.spring at gmx.de wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> sorry, but segfault seems to be still persistent on every request.
>
> Tried it with nightly build dowloaded May 19, 08:30 CST and with CVS
> version checked out at about the same time.
>
> I know it's a development version...
>
> Markus
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (GNU/Linux)
> Comment: Processed by Mailcrypt 3.5.6 and Gnu Privacy Guard
> <http://www.gnupg.org/>
>
> iD8DBQE+yIFpxxUzQSse11ARAmPdAJ9PKJpU0Bnlk3toWEpDrpEpHLmVEQCdFlec
> cbMHMM0+2uZca/ZZvOIgi1M=
> =1ACl
> -----END PGP SIGNATURE-----
> _______________________________________________
> Mapserver-dev mailing list
> Mapserver-dev at lists.gis.umn.edu
> http://lists.gis.umn.edu/mailman/listinfo/mapserver-dev

-- 
______________________________________
Vincent Schut
Sarvision B.V.
Wageningen, The Netherlands
www.sarvision.com